Skip to content

Update Timer screen metrics to show C1-C4 duration#7

Merged
c0d3rb4b4 merged 1 commit into
mainfrom
codex/update-timer-screen-details
Feb 23, 2026
Merged

Update Timer screen metrics to show C1-C4 duration#7
c0d3rb4b4 merged 1 commit into
mainfrom
codex/update-timer-screen-details

Conversation

@c0d3rb4b4
Copy link
Copy Markdown
Owner

Motivation

  • Surface a clearer, event-centric metric on the Timer screen by replacing the less-useful Magnitude value with a full-event C1-C4 Duration (elapsed time from first to last contact).
  • Use a clearer label for the existing central-path duration by renaming Central Duration to Totality Duration for better user understanding.

Description

  • Removed the Magnitude display and added C1-C4 Duration rendering in apps/mobile/src/screens/TimerScreen.tsx.
  • Implemented parseUtcTimestamp and formatC1ToC4Duration helpers to compute elapsed time from c1Utc to c4Utc with safe -- fallbacks when timestamps are missing or invalid.
  • Renamed the UI label Central Duration to Totality Duration while continuing to display the existing durationSeconds value.
  • Bumped mobile package version to 1.1.16 in apps/mobile/package.json and added a 1.1.16 entry to CHANGELOG.md documenting these changes.

Testing

  • Ran type checking with pnpm -C apps/mobile typecheck and it completed successfully.
  • Ran unit tests with pnpm -C apps/mobile test (Vitest) and all tests passed (5 test files, 16 tests total).

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4788eb779

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +758 to 760
<Text style={styles.metricLabel}>Totality Duration</Text>
<Text style={styles.metricValue}>
{formatDuration(timer.result.durationSeconds)}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep C2-C3 duration label accurate for annular eclipses

durationSeconds is derived from c2c3 for both total and annular events, so labeling it as Totality Duration is incorrect whenever kindAtLocation === "annular". In those cases the UI reports annularity time with a totality label, which is a user-facing accuracy issue; use a neutral label (e.g., central/phase duration) or switch the label by eclipse type.

Useful? React with 👍 / 👎.

@c0d3rb4b4 c0d3rb4b4 merged commit 5c983f7 into main Feb 23, 2026
1 check passed
@c0d3rb4b4 c0d3rb4b4 deleted the codex/update-timer-screen-details branch February 26, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant