Fix preview moon direction: use bearing-based 2D travel vector#5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
determinePreviewTravelVectorandbearingDegToUnitCirclePointand applied the vector to both X and Y positioning incalculatePreviewMoonGeometryso the moon path can include vertical drift. (apps/mobile/src/utils/previewGeometry.ts)describePreviewTravelDirectionto produce a short user-facing label for the computed vector and wired it into the preview UI asMoon path: .... (apps/mobile/src/utils/previewGeometry.ts,apps/mobile/src/screens/EclipsePreviewScreen.tsx)EclipsePreviewScreento compute and passtravelVectorinto the geometry calculation and to display the direction label. (apps/mobile/src/screens/EclipsePreviewScreen.tsx)apps/mobile/tests/preview-geometry.test.tsto validate diagonal travel vectors, fallback behavior when bearings are missing, and the user-facing direction string. (apps/mobile/tests/preview-geometry.test.ts)1.1.12and added a1.1.12entry toCHANGELOG.md. (apps/mobile/package.json,CHANGELOG.md)Testing
pnpm -C apps/mobile testand all mobile tests passed (5 files, 15 tests passed) includingpreview-geometry.test.ts(6 tests) which passed.pnpm -C apps/mobile test -- preview-geometry.test.tsand it passed.pnpm -C apps/mobile typecheckwith no errors.pnpm -C apps/mobile lintand fixed the reported unused-variable warning; the linter now reports clean.Codex Task