chore(release): bump mobile version to 1.1.10 and update changelog#3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7144f45695
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const internalTouchOffset = Math.abs(sunRadius - moonRadius); | ||
|
|
||
| const anchors: Array<{ progress: number; offsetX: number }> = [ | ||
| { progress: 0, offsetX: -externalTouchOffset }, |
There was a problem hiding this comment.
Honor earliest available contact at progress 0
EclipsePreviewScreen computes timeline start as c1 ?? firstMs, so payloads without c1Utc can legitimately have c2/max at progress 0. This hardcoded start anchor forces progress 0 to outer tangency, and interpolateOffsetX returns that value before considering the real first contact, so the moon is drawn in the wrong phase exactly at the first timestamp (for example, showing C2 as outer tangency instead of inner tangency).
Useful? React with 👍 / 👎.
Motivation
Description
apps/mobile/package.jsonversionto1.1.10and added a## [1.1.10]section toCHANGELOG.mddocumenting the eclipse preview geometry fix and associated regression tests.Testing
pnpm --filter @eclipse-timer/mobile test -- preview-geometry.test.tswhich executed 3 tests and all passed, and ranpnpm --filter @eclipse-timer/mobile lintwhich reported no issues.Codex Task