fix(wear): require release keystore for wear bundle signing#12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6e4f65d67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def isReleaseBuildRequested = gradle.startParameter.taskNames.any { taskName -> | ||
| taskName.toLowerCase().contains("release") |
There was a problem hiding this comment.
Limit release-signing guard to :wear release tasks
This check treats any Gradle task name containing release as a wear release build, so running unrelated commands like :app:assembleRelease will still throw [wear] Missing release signing config if wear signing props are absent. Because wear/build.gradle is evaluated during configuration, this can block non-wear release workflows that previously did not require wear credentials; the guard should be scoped to :wear release tasks (or task graph entries for the wear module) rather than global task names.
Useful? React with 👍 / 👎.
Motivation
releasebuilds which can cause accidental uploads signed with the wrong certificate.Description
apps/mobile/android/wear/build.gradleto detectreleasetasks and require injected release signing properties (android.injected.signing.*).releasesigning config that readsstoreFile,storePassword,keyAlias, andkeyPasswordfrom Gradle-injected properties provided by EAS/CI.releasebuild type to usesigningConfigs.releaseinstead of the debug keystore.GradleExceptionwith a clear message when areleasebuild is requested but signing properties are missing.Testing
./gradlew :wear:assembleDebugfromapps/mobile/android, which failed due toPermission deniedfor the wrapper in this environment.bash ./gradlew :wear:assembleDebugfromapps/mobile/android, which failed while downloading the Gradle distribution because the environment blocks external network/proxy access (HTTP/1.1 403 Forbidden).apps/mobile/android/wear/build.gradleand is designed to be verified by running a release build in EAS (or locally passingandroid.injected.signing.*properties) and confirming the AAB is signed with the expected upload key.Codex Task