Reduce timer-screen clutter and prioritize map area#10
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58325c8a63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fontSize: 11, | ||
| }, | ||
| mapWrap: { height: 300, marginHorizontal: 12, borderRadius: 12, overflow: "hidden" }, | ||
| mapWrap: { height: 420, marginHorizontal: 12, borderRadius: 12, overflow: "hidden" }, |
There was a problem hiding this comment.
Make map height responsive to avoid collapsing results panel
Hard-coding mapWrap to height: 420 can consume nearly all vertical space on short devices (for example 568pt screens), which leaves the results ScrollView with little or zero viewport and makes the timer output effectively inaccessible. This regression is introduced here because the previous fixed height was much smaller; using a responsive max/ratio (or clamping by screen height) would keep the results area usable across device sizes.
Useful? React with 👍 / 👎.
Motivation
Description
apps/mobile/src/screens/TimerScreen.tsx.mapWrapfrom300to360and tightened surrounding spacing and font sizes.mapActionsRow/mapActionBtn) and removed the separate controls row below the map.Add Favorite/Saved, reduced paddings) to reduce vertical footprint.Testing
pnpm -C apps/mobile lintwhich completed successfully.pnpm -C apps/mobile typecheckwhich completed successfully.pnpm -C apps/mobile web -- --port 19006but Expo web failed becausewebis not included inplatformsinapp.json, so no browser render verification was captured.Codex Task