Skip to content

Reduce timer-screen clutter and prioritize map area#10

Merged
c0d3rb4b4 merged 3 commits into
mainfrom
codex/improve-timer-screen-layout
Feb 23, 2026
Merged

Reduce timer-screen clutter and prioritize map area#10
c0d3rb4b4 merged 3 commits into
mainfrom
codex/improve-timer-screen-layout

Conversation

@c0d3rb4b4
Copy link
Copy Markdown
Owner

Motivation

  • The timer screen was visually busy and constrained the map; the change reduces vertical chrome to give the map more prominence.
  • Assumed consolidating actions into compact in-map controls preserves functionality while simplifying the layout.

Description

  • Condensed the Active Eclipse switcher into a denser single-row primary line with a shorter metadata line in apps/mobile/src/screens/TimerScreen.tsx.
  • Increased the map viewport height by changing mapWrap from 300 to 360 and tightened surrounding spacing and font sizes.
  • Moved the "Greatest Eclipse" and favorite-save actions into compact floating map pills (mapActionsRow / mapActionBtn) and removed the separate controls row below the map.
  • Minor label and style tweaks (e.g. Add Favorite / Saved, reduced paddings) to reduce vertical footprint.

Testing

  • Ran pnpm -C apps/mobile lint which completed successfully.
  • Ran pnpm -C apps/mobile typecheck which completed successfully.
  • Attempted pnpm -C apps/mobile web -- --port 19006 but Expo web failed because web is not included in platforms in app.json, so no browser render verification was captured.

Codex Task

@c0d3rb4b4 c0d3rb4b4 marked this pull request as ready for review February 23, 2026 23:10
@c0d3rb4b4
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58325c8a63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/mobile/src/screens/TimerScreen.tsx Outdated
fontSize: 11,
},
mapWrap: { height: 300, marginHorizontal: 12, borderRadius: 12, overflow: "hidden" },
mapWrap: { height: 420, marginHorizontal: 12, borderRadius: 12, overflow: "hidden" },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make map height responsive to avoid collapsing results panel

Hard-coding mapWrap to height: 420 can consume nearly all vertical space on short devices (for example 568pt screens), which leaves the results ScrollView with little or zero viewport and makes the timer output effectively inaccessible. This regression is introduced here because the previous fixed height was much smaller; using a responsive max/ratio (or clamping by screen height) would keep the results area usable across device sizes.

Useful? React with 👍 / 👎.

Comment thread apps/mobile/src/screens/TimerScreen.tsx
@c0d3rb4b4 c0d3rb4b4 merged commit 74f2b36 into main Feb 23, 2026
1 check passed
@c0d3rb4b4 c0d3rb4b4 deleted the codex/improve-timer-screen-layout branch February 26, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant