From 3438b1b97ce2c5daac6bd9dbeef73e978a47c1e6 Mon Sep 17 00:00:00 2001 From: Alex Wu Date: Sun, 20 Aug 2017 13:00:10 +0800 Subject: [PATCH 1/2] mci 0 will result a out-of-memory by div 10 always true --- main_chain.js | 1 + 1 file changed, 1 insertion(+) diff --git a/main_chain.js b/main_chain.js index 37138f65..8f85ced2 100644 --- a/main_chain.js +++ b/main_chain.js @@ -916,6 +916,7 @@ function markMcIndexStable(conn, mci, onDone){ function getSimilarMcis(mci){ var arrSimilarMcis = []; var divisor = 10; + if (mci <= 0) return arrSimilarMcis; while (true){ if (mci % divisor === 0){ arrSimilarMcis.push(mci - divisor); From 1f62efb5073abfbf42d90df4190f1c63abbb678d Mon Sep 17 00:00:00 2001 From: Alex Wu Date: Tue, 17 Oct 2017 13:20:16 +0800 Subject: [PATCH 2/2] small code change to handle mci=0 after code review --- main_chain.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main_chain.js b/main_chain.js index 8f85ced2..fb14cf50 100644 --- a/main_chain.js +++ b/main_chain.js @@ -915,8 +915,9 @@ function markMcIndexStable(conn, mci, onDone){ // returns list of past MC indices for skiplist function getSimilarMcis(mci){ var arrSimilarMcis = []; + if (mci <= 0) + return arrSimilarMcis; var divisor = 10; - if (mci <= 0) return arrSimilarMcis; while (true){ if (mci % divisor === 0){ arrSimilarMcis.push(mci - divisor);