From dd5c1cb7932adf068fcc6243870418127f4cf2aa Mon Sep 17 00:00:00 2001 From: TedBusto <38771596+TedBusto@users.noreply.github.com> Date: Thu, 9 May 2019 16:00:19 -0400 Subject: [PATCH] Reduced Lookup Removed a lookup on ManagedBy by using some Regex to converting DistinguishedName to Name --- PSHTML-AD.ps1 | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/PSHTML-AD.ps1 b/PSHTML-AD.ps1 index e7aac2c..80a4ae2 100644 --- a/PSHTML-AD.ps1 +++ b/PSHTML-AD.ps1 @@ -655,17 +655,8 @@ foreach ($Group in $Groups) $Users = "Skipped Domain Users Membership" } - $OwnerDN = Get-ADGroup -Filter { name -eq $Group.Name } -Properties managedBy | Select-Object -ExpandProperty ManagedBy - Try - { - $Manager = Get-ADUser -Filter { distinguishedname -like $OwnerDN } | Select-Object -ExpandProperty Name - } - Catch - { - write-host -ForegroundColor Yellow "Cannot resolve the manager, " $Manager " on the group " $group.name - } + $Manager = (Get-ADGroup -Filter { name -eq $Group.Name } -Properties managedBy | Select-Object -ExpandProperty ManagedBy) -replace '^CN=|,.*$' - #$Manager = $AllUsers | Where-Object { $_.distinguishedname -eq $OwnerDN } | Select-Object -ExpandProperty Name $obj = [PSCustomObject]@{