Skip to content

std::optional instead of std::tuple #1

@MLIOSBond

Description

@MLIOSBond

I assume that this library is based on C++17 (by using std::variant) — so wouldn't it be better to replace std::tuple with std::optional in the Parse function?

Suggestion:

std::optional<DnsMessage> Parse(const uint8_t *buf, size_t bufSize)

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions