[BUG] Bazel 9 compatibility issues

[ash2k]

Description

I'm trying to build my project, that uses protovalidate, with Bazel 9.

Steps to Reproduce

Expected Behavior

Successful build.

Actual Behavior

The build is failing:

bazel test -- //...
ERROR: .../external/protovalidate+/proto/protovalidate/buf/validate/BUILD.bazel:39:1: name 'cc_proto_library' is not defined (did you mean 'proto_library'?)
ERROR: .../external/protovalidate+/proto/protovalidate/buf/validate/BUILD.bazel: no such target '@@protovalidate+//proto/protovalidate/buf/validate:validate_proto': target 'validate_proto' not declared in package 'proto/protovalidate/buf/validate' defined by .../external/protovalidate+/proto/protovalidate/buf/validate/BUILD.bazel
ERROR: /Users/mike/src/gitlab-agent/pkg/agentcfg/BUILD.bazel:7:18: no such target '@@protovalidate+//proto/protovalidate/buf/validate:validate_proto': target 'validate_proto' not declared in package 'proto/protovalidate/buf/validate' defined by .../external/protovalidate+/proto/protovalidate/buf/validate/BUILD.bazel and referenced by '//pkg/agentcfg:proto'

Screenshots/Logs

Environment

• Operating System:
• Version:
• Compiler/Toolchain:
• Protobuf Compiler & Version:
• Protovalidate Version:

Possible Solution

As the error says, cc_proto_library is not imported properly. It used to be a built-in rule but that is no longer the case with Bazel 9. It must be imported from here.

Additional Context

Ideally this project should switch from the deprecated rules_proto to protobuf. This would make it possible to use pre-built protoc too.

[kberezin-nshl]

Apparently, it was fixed in this commit already: 087f587

However, there was no release yet with it. Also, 1.1.0 also wasn't published to BCR.

@timostamm could you tell us please, when can we expect the release with Bazel 9 compatibility established?

[timostamm]

The release is till going through the process on https://github.com/bazelbuild/bazel-central-registry

[kberezin-nshl]

Great. But also the commit that I am referring to is not included in 1.1.0, so we need another release to make this module compatible with Bazel 9

[kberezin-nshl]

When can we expect a new release that includes Bazel 9 compatibility change @timostamm ?

[timostamm]

1.1.0 made it to the BCR yesterday. We are planning to cut a patch release including #454 soon.

[timostamm]

v1.1.1 including #454 is released.

Judging from past releases, it will take a while to become available on the BCR. Hopefully the process will become a bit quicker over time 🙂

[kberezin-nshl]

Amazing! Thank you very much!

[ash2k]

BCR PR is here bazelbuild/bazel-central-registry#7446, but it's not being merged because it is a draft, like the previous one: bazelbuild/bazel-central-registry#6760. Some script somewhere needs to be updated?

[timostamm]

v1.1.1 is available on the BCR. If there are still any issues, let us know.