Remove init logic from coinbase placeholder (#7)

* Remove init logic from coinbase placeholder

* Update coinbase_placeholder_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: galt-tr

.golangci.json

@@ -44,19 +44,16 @@
   },
   "linters": {
     "disable": [
-      "gochecknoglobals",
       "gocritic",
       "godot",
       "godox",
       "testifylint",
       "revive",
-      "gochecknoinits",
       "forbidigo",
       "err113",
       "errorlint",
       "gosec",
-      "unused",
-      "gomoddirectives"
+      "unused"
     ],
     "enable": [
       "asasalint",

coinbase_placeholder.go

@@ -28,19 +28,17 @@ var (
 	FrozenBytesTxHash  = chainhash.Hash(FrozenBytesTxBytes)
 )
 
-var (
-	CoinbasePlaceholderTx     *bt.Tx
-	coinbasePlaceholderTxHash *chainhash.Hash
-)
-
-func init() {
-	CoinbasePlaceholderTx = bt.NewTx()
-	CoinbasePlaceholderTx.Version = 0xFFFFFFFF
-	CoinbasePlaceholderTx.LockTime = 0xFFFFFFFF
-
-	coinbasePlaceholderTxHash = CoinbasePlaceholderTx.TxIDChainHash()
+func generateCoinbasePlaceholderTx() *bt.Tx {
+	tx := bt.NewTx()
+	tx.Version = 0xFFFFFFFF
+	tx.LockTime = 0xFFFFFFFF
+	return tx
 }
 
+// IsCoinbasePlaceHolderTx checks if the given transaction is a coinbase placeholder transaction.
 func IsCoinbasePlaceHolderTx(tx *bt.Tx) bool {
+	coinbasePlaceholderTx := generateCoinbasePlaceholderTx()
+
+	coinbasePlaceholderTxHash := coinbasePlaceholderTx.TxIDChainHash()
 	return tx.TxIDChainHash().IsEqual(coinbasePlaceholderTxHash)
 }

coinbase_placeholder_test.go

@@ -8,10 +8,12 @@ import (
 )
 
 func TestCoinbasePlaceholderTx(t *testing.T) {
-	assert.True(t, IsCoinbasePlaceHolderTx(CoinbasePlaceholderTx))
-	assert.Equal(t, CoinbasePlaceholderTx.Version, uint32(0xFFFFFFFF))
-	assert.Equal(t, CoinbasePlaceholderTx.LockTime, uint32(0xFFFFFFFF))
-	assert.Equal(t, CoinbasePlaceholderTx.TxIDChainHash(), coinbasePlaceholderTxHash)
+	coinbasePlaceholderTx := generateCoinbasePlaceholderTx()
+	coinbasePlaceholderTxHash := coinbasePlaceholderTx.TxIDChainHash()
+	assert.True(t, IsCoinbasePlaceHolderTx(coinbasePlaceholderTx))
+	assert.Equal(t, uint32(0xFFFFFFFF), coinbasePlaceholderTx.Version)
+	assert.Equal(t, coinbasePlaceholderTx.LockTime, uint32(0xFFFFFFFF))
+	assert.Equal(t, coinbasePlaceholderTx.TxIDChainHash(), coinbasePlaceholderTxHash)
 	assert.False(t, IsCoinbasePlaceHolderTx(bt.NewTx()))
-	assert.Equal(t, "a8502e9c08b3c851201a71d25bf29fd38a664baedb777318b12d19242f0e46ab", CoinbasePlaceholderTx.TxIDChainHash().String())
+	assert.Equal(t, "a8502e9c08b3c851201a71d25bf29fd38a664baedb777318b12d19242f0e46ab", coinbasePlaceholderTx.TxIDChainHash().String())
 }