linting fixes

Author: freemans13

errors.go

@@ -65,4 +65,13 @@ var (
 
 	// ErrReadError is a generic read error for testing
 	ErrReadError = errors.New("read error")
+
+	// ErrTransactionNil is returned when a transaction is nil during serialization
+	ErrTransactionNil = errors.New("transaction is nil, cannot serialize")
+
+	// ErrTransactionWrite is returned when writing a transaction fails
+	ErrTransactionWrite = errors.New("error writing transaction")
+
+	// ErrTransactionRead is returned when reading a transaction fails
+	ErrTransactionRead = errors.New("error reading transaction")
 )

subtree_data.go

@@ -135,13 +135,13 @@ func (s *Data) WriteTransactionsToWriter(w io.Writer, startIdx, endIdx int) erro
 		}
 
 		if s.Txs[i] == nil {
-			return fmt.Errorf("transaction at index %d is nil, cannot serialize", i)
+			return ErrTransactionNil
 		}
 
 		// Serialize and stream transaction bytes to writer
 		txBytes := s.Txs[i].SerializeBytes()
 		if _, err := w.Write(txBytes); err != nil {
-			return fmt.Errorf("error writing transaction at index %d: %w", i, err)
+			return fmt.Errorf("%w at index %d: %w", ErrTransactionWrite, i, err)
 		}
 	}
 
@@ -176,7 +176,7 @@ func (s *Data) ReadTransactionsFromReader(r io.Reader, startIdx, endIdx int) (in
 			if errors.Is(err, io.EOF) {
 				break
 			}
-			return txsRead, fmt.Errorf("error reading transaction at index %d: %w", i, err)
+			return txsRead, fmt.Errorf("%w at index %d: %w", ErrTransactionRead, i, err)
 		}
 
 		// Validate tx hash matches expected

subtree_data_test.go

@@ -397,7 +397,7 @@ func setupTestSubtreeData(t *testing.T) (*Subtree, *Data, []*bt.Tx) {
 	txs := make([]*bt.Tx, 4)
 	for i := range txs {
 		txs[i] = tx.Clone()
-		txs[i].Version = uint32(i + 1)
+		txs[i].Version = uint32(i + 1) //nolint:gosec // G115: test data, safe conversion
 	}
 
 	subtree, err := NewTree(2)
@@ -447,8 +447,7 @@ func TestWriteTransactionsToWriter(t *testing.T) {
 
 		buf := &bytes.Buffer{}
 		err := subtreeData.WriteTransactionsToWriter(buf, 0, 2)
-		require.Error(t, err)
-		assert.Contains(t, err.Error(), "transaction at index 1 is nil")
+		require.ErrorIs(t, err, ErrTransactionNil)
 	})
 }
 
@@ -495,7 +494,7 @@ func TestReadTransactionsFromReader(t *testing.T) {
 		// Try to read more transactions than available
 		targetData := NewSubtreeData(subtree)
 		numRead, err := targetData.ReadTransactionsFromReader(bytes.NewReader(serialized), 0, 10)
-		require.NoError(t, err) // EOF not an error
+		require.NoError(t, err)     // EOF not an error
 		assert.Equal(t, 4, numRead) // Only 4 available
 	})
 }