Fix #1: Implement Median function#8
Open
tannadevp wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
medianfunction forf64slices in the primary module.Completed issue requirements:
src/primary/median.rsmedianinsrc/primary/mod.rsmedianfunctionImplementation:
Nonefor empty inputpartial_cmpfor orderingf64values and rejectsNaNvaluesThe issue mentions
primary/lib.rs, but this repository usessrc/primary/mod.rsfor the primary module, so median has been declared and re-exported there.Essential Checklist
Proof that changes are correct
Verified locally with:
cargo test --test median: passes for all the 11 median-specific testscargo test: attempts to compile for variance and std_devation as well, which are unimplemented functions/issuescargo check: successfully executedcargo fmtLooking forward to your feedback. Please let me know if any changes are required. Thank you for reviewing!