Playback rate affects position when unpausing

[bobsayshilol]

Description

The position jumps around depending on the current playback rate when unpausing.

Expected Behavior

Hitting play after pause should continue from where it was paused.

Steps to Reproduce

1. Load any song
2. Click ~half way through the song in the waveform viewer
3. Increase the playback rate
4. Play -> pause -> play -> pause -> play -> pause
5. Observe that the current position jumps backwards

Alternatively, decrease the playback rate and observe that the current position jumps forwards (assuming there's enough song left)

Environment

• App Version: 0.5.0
• Device: Desktop
• OS: Linux
• Browser: Firefox

Additional Context

My guess is that it's this division (or lack of a corresponding division in pause()) that's causing the issue since the jump is proportional to the playback rate:

beatmapper/src/services/audio.service.ts

Line 98 in c55892c

this.startTime = this.context.currentTime - actualOffset / this.playbackRate;

[officialMECH]

found the actual culprit:

beatmapper/src/services/audio.service.ts

Lines 140 to 143 in c55892c

	getCurrentTime() {
	if (!this.isPlaying) return this.startOffset;
	return this.getRateAdjustedElapsed() + (this.playbackRateLastSetAt - this.startTime);
	}

tfw you forget to apply the playback rate to the only field that's explicitly called by the tick loop, love to see it. 🙃
ty for the report! will be fixed for next patch update.