Skip to content

Commit 16c8123

Browse files
committed
make FontStyle tests more robust and cleanups
1 parent 1861a9e commit 16c8123

3 files changed

Lines changed: 15 additions & 13 deletions

File tree

PythonScript/python_tests/RunTests.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ def main():
1414
) == MESSAGEBOXFLAGS.RESULTNO:
1515
return
1616

17-
1817
# unittest module expects argv to be set
1918
sys.argv = ['']
2019

PythonScript/python_tests/tests/test_NotepadWrapperTestCase.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1603,7 +1603,7 @@ def test_lineNumberWidthMode(self):
16031603
revert_changed_mode = notepad.getLineNumberWidthMode()
16041604
self.assertTrue(revert_changed_mode == mode, msg="Expected same modes, got {} and {}".format(mode, changed_mode))
16051605

1606-
1606+
# TODO: How can this be tested in a meaningful way?
16071607
def test_getExternalLexerAutoIndentMode(self):
16081608
''' '''
16091609
notepad_method = notepad.getExternalLexerAutoIndentMode
@@ -1618,19 +1618,20 @@ def test_getExternalLexerAutoIndentMode(self):
16181618
with self.assertRaises(ArgumentError):
16191619
self._invalid_parameter_passed(notepad_method, '','')
16201620

1621-
1621+
# TODO: How can this be tested in a meaningful way?
16221622
def test_setExternalLexerAutoIndentMode(self):
16231623
''' '''
16241624
self.__test_invalid_parameter_passed(notepad.setExternalLexerAutoIndentMode)
16251625

1626-
1626+
# TODO: How can this be tested in a meaningful way?
16271627
def test_isAutoIndention(self):
16281628
''' '''
16291629
self.__test_invalid_parameter_passed(notepad.isAutoIndention)
16301630

16311631

1632+
suite = unittest.TestLoader().loadTestsFromTestCase(NotepadTestCase)
1633+
16321634
if __name__ == '__main__':
1633-
suite = unittest.TestLoader().loadTestsFromTestCase(NotepadTestCase)
16341635
alltests = unittest.TestSuite(suite)
16351636

16361637
results = unittest.TestResult()
@@ -1653,10 +1654,7 @@ def writeTestFailure(error):
16531654
console.writeError('Tests Run: {}\n Errors : {}\n Failures: {}\n'.format(results.testsRun, len(results.errors), len(results.failures)))
16541655
else:
16551656
console.write('Tests Run: {}\n Errors : {}\n Failures: {}\n'.format(results.testsRun, len(results.errors), len(results.failures)))
1656-
if results.skipped:
1657-
console.write('Skipped: {}\n'.format(len(results.skipped)))
1658-
for skipped_test in results.skipped:
1659-
console.write(' {} - {}\n'.format(skipped_test[0], skipped_test[1]))
1660-
# console.show()
1661-
else:
1662-
suite = unittest.TestLoader().loadTestsFromTestCase(NotepadTestCase)
1657+
if results.skipped:
1658+
console.write('Skipped: {}\n'.format(len(results.skipped)))
1659+
for skipped_test in results.skipped:
1660+
console.write(' {} - {}\n'.format(skipped_test[0], skipped_test[1]))

PythonScript/python_tests/tests/test_ScintillaWrapperTestCase.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,11 @@ def callback_scintillawrapper_void_int_string(self, args):
347347

348348
def test_scintillawrapper_void_int_string_in_callback(self):
349349
editor.callback(lambda args: self.callback_scintillawrapper_void_int_string(args), [SCINTILLANOTIFICATION.MODIFIED])
350+
original_mask = editor.getModEventMask()
351+
editor.setModEventMask(MODIFICATIONFLAGS.INSERTTEXT)
350352
editor.write("test")
351353
self.poll_for_callback()
354+
editor.setModEventMask(original_mask)
352355
self.assertEqual(self.callbackCalled, True)
353356

354357
def test_scintillawrapper_int_void_void(self):
@@ -634,11 +637,13 @@ def callback_scintillawrapper_int_int_stringresult_styleGetFont(self, args):
634637

635638
def test_scintillawrapper_int_int_stringresult_in_callback_styleGetFont(self):
636639
editor.callback(lambda args: self.callback_scintillawrapper_int_int_stringresult_styleGetFont(args), [SCINTILLANOTIFICATION.MODIFIED])
640+
original_mask = editor.getModEventMask()
641+
editor.setModEventMask(MODIFICATIONFLAGS.INSERTTEXT)
637642
editor.write("test")
638643
self.poll_for_callback()
644+
editor.setModEventMask(original_mask)
639645
self.assertEqual(self.callbackCalled, True)
640646

641-
642647
def callback_scintillawrapper_int_int_stringresult_getLine(self, args):
643648
lineTwo = editor.getLine(1)
644649
lineThree = editor.getLine(2)

0 commit comments

Comments
 (0)