Add better commenting regrding test removals

Author: lukechilds

test/parallel/test-assert-async.js

@@ -1,6 +1,13 @@
 // Currently in sync with Node.js test/parallel/test-assert-async.js
 // https://github.com/nodejs/node/commit/2a51ae424a513ec9a6aa3466baa0cc1d55dd4f3b
 
+// [browserify]
+// Most `err.message` and `err.stack` tests are commented out because they are
+// inconsistent between browsers.
+//
+// `err.operator` tests are commented out because its always `undefined` in IE.
+// If we drop IE support we can uncomment these tests.
+
 'use strict';
 const common = require('../common');
 const assert = require('../../assert');
@@ -78,7 +85,6 @@ const invalidThenableFunc = () => {
     assert.strictEqual(err.code, 'ERR_ASSERTION');
     // assert.strictEqual(err.message,
     //                    'Missing expected rejection (mustNotCall).');
-    // [browserify] This will be undefined in IE
     // assert.strictEqual(err.operator, 'rejects');
     assert.ok(!common.includes(err.stack, 'at Function.rejects'));
     return true;
@@ -202,7 +208,6 @@ promises.push(assert.rejects(
     assert.strictEqual(err.code, 'ERR_ASSERTION');
     assert.strictEqual(err.actual, actual);
     // assert.strictEqual(err.operator, 'rejects');
-    // [browserify] Don't worry if the stack is less reliable
     // assert(/rejects/.test(err.stack));
     return true;
   };

test/parallel/test-assert-checktag.js

@@ -1,6 +1,10 @@
 // Currently in sync with Node.js test/parallel/test-assert-checktag.js
 // https://github.com/nodejs/node/commit/7493db21b667ed746d39c9b54357eac4287232e3
 
+// [browserify]
+// Most `err.message` tests are commented out because they are
+// inconsistent between browsers.
+
 'use strict';
 const {isBrowser} = require('../common');
 const assert = require('../../assert');

test/parallel/test-assert-deep.js

@@ -1,6 +1,10 @@
 // Currently in sync with Node.js test/parallel/test-assert-deep.js
 // https://github.com/nodejs/node/commit/1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09
 
+// [browserify]
+// Most `err.message` tests are commented out because they are
+// inconsistent between browsers.
+
 'use strict';
 
 const common = require('../common');
@@ -965,8 +969,7 @@ assert.deepStrictEqual(obj1, obj2);
     util.inspect.defaultOptions = tmp;
   }
 
-  // [browserify] Safari fails this test. I'm not sure why, Chrome and Firefox pass.
-  // @BridgeAR is it ok to comment out this test?
+  // [browserify] Safari fails this test due to the proxy. Chrome and Firefox pass.
   // const invalidTrap = new Proxy([1, 2, 3], {
   //   ownKeys() { return []; }
   // });

test/parallel/test-assert-if-error.js

@@ -1,6 +1,10 @@
 // Currently in sync with Node.js test/parallel/test-assert-if-error.js
 // https://github.com/nodejs/node/commit/644fdd60d4be49ffa66d0bda1702c4459f607635
 
+// [browserify]
+// Most `err.message` and `err.stack` tests are commented out because they are
+// inconsistent between browsers.
+
 'use strict';
 
 require('../common');
@@ -86,7 +90,6 @@ assert.ifError(undefined);
   } catch (e) {
     threw = true;
     assert.strictEqual(e.message, 'Missing expected exception.');
-    // [browserify] Don't worry if stack is missing info
     // assert(!e.stack.includes('throws'), e.stack);
   }
   assert(threw);

test/parallel/test-assert.js

@@ -23,6 +23,13 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+// [browserify]
+// Most `err.message` and `err.stack` tests are commented out because they are
+// inconsistent between browsers.
+//
+// `err.operator` tests are commented out because its always `undefined` in IE.
+// If we drop IE support we can uncomment these tests.
+
 'use strict';
 
 const arrayFill = require('array-fill');

test/pseudo-tty/test-assert-colors.js

@@ -24,6 +24,8 @@ try {
     '\u001b[34m...\u001b[39m\n' +
     '    2\n' +
     '  ]';
+  // [browserify]
+  // Don't test the exact message, it's inconstent between browsers.
   // assert.strictEqual(err.message, expected);
   if(process.stderr && process.stderr.getColorDepth) {
     assert(err.message.indexOf('[32m') > -1);

test/pseudo-tty/test-assert-no-color.js

@@ -18,6 +18,8 @@ try {
     '- {\n' +
     '-   foo: \'bar\'\n' +
     '- }';
+  // [browserify]
+  // Don't test the exact message, it's inconstent between browsers.
   // assert.strictEqual(error.message, expected);
   assert(error.message.indexOf('[32m') === -1);
 }