From bbfea0a7c6db24cecc111e34bc6f1e3e2ee59ea9 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Wed, 6 May 2026 13:42:42 +0900 Subject: [PATCH] fix: drop 32-bit architecture support 32-bit architecture (x32/i686) is not a valid return value from os.arch() in practice. The only GitHub Actions runner with a 32-bit architecture is Linux ARM, but Microsoft Edge does not distribute builds for Linux 32-bit ARM. Keeping the mapping was misleading and could result in a silent lookup failure. Remove the I686 arch constant, the x32 detection branch in getArch(), and the x86 API mapping so unsupported architectures now fail fast with a clear error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/edge_api.ts | 1 - src/platform.ts | 3 --- 2 files changed, 4 deletions(-) diff --git a/src/edge_api.ts b/src/edge_api.ts index a0aa90e..1e2f636 100644 --- a/src/edge_api.ts +++ b/src/edge_api.ts @@ -62,7 +62,6 @@ export class EdgeUpdatesProduct { }; private static readonly ArchValues = { - [Arch.I686]: "x86", [Arch.AMD64]: "x64", [Arch.ARM64]: "arm64", }; diff --git a/src/platform.ts b/src/platform.ts index f6d54df..decb728 100644 --- a/src/platform.ts +++ b/src/platform.ts @@ -15,7 +15,6 @@ export type OS = (typeof OS)[keyof typeof OS]; export const Arch = { AMD64: "amd64", - I686: "i686", ARM64: "arm64", } as const; @@ -37,8 +36,6 @@ export const getOS = (): OS => { export const getArch = (): Arch => { const arch = os.arch(); switch (arch) { - case "x32": - return Arch.I686; case "x64": return Arch.AMD64; case "arm64":