From 39f299f91c44236afb1bdf83fea8cc85638a9bf1 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Wed, 6 May 2026 13:30:31 +0900 Subject: [PATCH] feat: drop 32-bit architecture support Chrome is not distributed for Linux 32-bit ARM, which is the only GitHub Actions runner platform with a 32-bit architecture. Supporting it adds dead code paths that can never be exercised, so remove the i686/x32 handling entirely and let unsupported architectures fail with a clear error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/chrome_for_testing.ts | 2 -- src/platform.ts | 3 --- src/snapshot_bucket.ts | 4 ---- 3 files changed, 9 deletions(-) diff --git a/src/chrome_for_testing.ts b/src/chrome_for_testing.ts index 2a655b0..1068fc0 100644 --- a/src/chrome_for_testing.ts +++ b/src/chrome_for_testing.ts @@ -70,8 +70,6 @@ const platformString = (platform: Platform): PlatformString => { return "mac-arm64"; } else if (platform.os === OS.WINDOWS && platform.arch === Arch.AMD64) { return "win64"; - } else if (platform.os === OS.WINDOWS && platform.arch === Arch.I686) { - return "win32"; } throw new Error(`Unsupported platform: ${platform.os} ${platform.arch}`); }; diff --git a/src/platform.ts b/src/platform.ts index b58eb60..189a0b1 100644 --- a/src/platform.ts +++ b/src/platform.ts @@ -16,7 +16,6 @@ export type OS = (typeof OS)[keyof typeof OS]; export const Arch = { AMD64: "amd64", - I686: "i686", ARM64: "arm64", } as const; @@ -39,8 +38,6 @@ export const getOS = (): OS => { export const getArch = (): Arch => { const arch = os.arch(); switch (arch) { - case "x32": - return Arch.I686; case "x64": return Arch.AMD64; case "arm64": diff --git a/src/snapshot_bucket.ts b/src/snapshot_bucket.ts index 971d705..94fa704 100644 --- a/src/snapshot_bucket.ts +++ b/src/snapshot_bucket.ts @@ -65,12 +65,8 @@ const makePlatformPart = ({ os, arch }: Platform): string => { return "Mac"; } else if (os === OS.DARWIN && arch === Arch.ARM64) { return "Mac_Arm"; - } else if (os === OS.LINUX && arch === Arch.I686) { - return "Linux"; } else if (os === OS.LINUX && arch === Arch.AMD64) { return "Linux_x64"; - } else if (os === OS.WINDOWS && arch === Arch.I686) { - return "Win"; } else if (os === OS.WINDOWS && arch === Arch.AMD64) { return "Win_x64"; } else if (os === OS.WINDOWS && arch === Arch.ARM64) {