Performance is terrible on DynamicLoader

[flarb]

Maybe it's due to the null exceptions, but the DynamicLoader scene brings my MacBook Pro to its knees. Didn't have this problem with previous versions. Not sure what the problem is, because when I try to run the profiler, Unity hangs.

[brnkhy]

Exceptions and logging pretty much always kills the machine. I'll look into that exceptions, then investigate performance things if you're still getting those freezes

[brnkhy]

I'm not sure if this is still an issue but just as an heads up, initial loading will become much worse with cached dynamic loader. I explained it in the last post. Guess I should do something about these performance issues asap.

[flarb]

I haven't used any of the newer drops of this code because of the performance issues. So I'm not sure if it was fixed or not.

[createthis]

It appears to be the triangulation code that causes some of the loading snags, according to the deep profiler. Specifically, BuildingFactory.CreateRoofTriangulation().

[brnkhy]

@createthis I'm using a library (triangulation.net) for that so I don't have much idea what goes inside it. You can try replacing that with a simpler algorithm like earclipping (I used to use that as well) but might not be stable, sound or complete (wasn't for me).

[createthis]

I've been thinking about this. Probably just queuing building creation and only doing a certain number of triangulation operations per frame would be sufficient.

[createthis]

System.Threading with a Job Queue is the solution here. In my local rewrite of this project (to understand how it works), I store the tiles as GeoJSON on disk for caching. My JSON library is super slow, so I queue the loading of the GeoJSON in a different thread, using a job queue, then I build my tiles in the main thread when the jobs have completed. I triangulate the building top using Triangulate.NET, but then I extrude everything manually and it's quite fast with zero loading framerate drop.