Skip to content

Commit b42b463

Browse files
authored
Merge pull request #159 from britive/fix/missing-profile-type-kwarg
Fix/missing profile type kwarg
2 parents 2584452 + ee0a706 commit b42b463

File tree

3 files changed

+30
-5
lines changed

3 files changed

+30
-5
lines changed

CHANGELOG.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,29 @@
33
* As of v1.4.0 release candidates will be published in an effort to get new features out faster while still allowing
44
time for full QA testing before moving the release candidate to a full release.
55

6+
## v1.8.0rc4 [2024-06-07]
7+
8+
__What's New:__
9+
10+
* None
11+
12+
__Enhancements:__
13+
14+
* None
15+
16+
__Bug Fixes:__
17+
18+
* missing `profile_type` kwarg in `ls profiles`.
19+
* `None` type handling for `my-resources` profiles.
20+
21+
__Dependencies:__
22+
23+
* None
24+
25+
__Other:__
26+
27+
* None
28+
629
## v1.8.0rc3 [2024-06-07]
730

831
__What's New:__

src/pybritive/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.8.0rc3'
1+
__version__ = '1.8.0rc4'

src/pybritive/britive_cli.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -346,9 +346,9 @@ def list_resources(self):
346346
found_resource_names.append(name)
347347
self.print(resources, ignore_silent=True)
348348

349-
def list_profiles(self, checked_out: bool = False):
349+
def list_profiles(self, checked_out: bool = False, profile_type: str = None):
350350
self.login()
351-
self._set_available_profiles()
351+
self._set_available_profiles(profile_type=profile_type)
352352
data = []
353353
checked_out_profiles = {}
354354
if checked_out: # only make this call if we have to
@@ -368,10 +368,10 @@ def list_profiles(self, checked_out: bool = False):
368368
profile_is_checked_out = key in checked_out_profiles
369369
if not checked_out or profile_is_checked_out:
370370
row = {
371-
'Application': profile['app_name'],
371+
'Application': profile['app_name'] or 'Resources',
372372
'Environment': profile['env_name'],
373373
'Profile': profile['profile_name'],
374-
'Description': profile['profile_description'],
374+
'Description': profile['profile_description'] or 'Resource',
375375
'Type': profile['app_type'],
376376
}
377377

@@ -986,6 +986,8 @@ def cache_profiles(self, from_cache_command=False):
986986

987987
@staticmethod
988988
def escape_profile_element(element):
989+
if element is None:
990+
element = 'resources'
989991
return element.replace('/', '\\/')
990992

991993
@staticmethod

0 commit comments

Comments
 (0)