Skip to content

Commit 9f4f487

Browse files
leogdionclaude
andcommitted
Fix full matrix not running on PRs
- configure: guard ci-skip check with event_name check so it always runs on pull_request events (github.event.head_commit is null on PRs) - build-macos: add needs: [configure], gate on configure success so ci-skip propagates via dependency chain instead of re-checking head_commit.message Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 9efa950 commit 9f4f487

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/SyntaxKit.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
configure:
2626
name: Configure Build Matrix
2727
runs-on: ubuntu-latest
28-
if: ${{ !contains(github.event.head_commit.message, 'ci skip') }}
28+
if: ${{ github.event_name == 'pull_request' || !contains(github.event.head_commit.message, 'ci skip') }}
2929
outputs:
3030
full-matrix: ${{ steps.set-matrix.outputs.full-matrix }}
3131
ubuntu-os: ${{ steps.set-matrix.outputs.ubuntu-os }}
@@ -110,10 +110,11 @@ jobs:
110110

111111
build-macos:
112112
name: Build on macOS
113+
needs: [configure]
113114
env:
114115
PACKAGE_NAME: SyntaxKit
115116
runs-on: ${{ matrix.runs-on }}
116-
if: ${{ !contains(github.event.head_commit.message, 'ci skip') }}
117+
if: ${{ !cancelled() && needs.configure.result == 'success' }}
117118
strategy:
118119
fail-fast: false
119120
matrix:

0 commit comments

Comments
 (0)