From 185d1c9d815049327b334f075d5edfe64c85eab3 Mon Sep 17 00:00:00 2001 From: alxndrsn Date: Fri, 15 Mar 2024 09:19:49 +0000 Subject: [PATCH 1/4] ci: run on push & all PRs --- .github/workflows/ci.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f4732dc..757418f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,10 +1,6 @@ name: Node.js CI -on: - push: - branches: [master] - pull_request: - branches: [master] +on: [push, pull_request] jobs: build: From e2bc89e377fa9d195b072f8af6bd4303aab8e3aa Mon Sep 17 00:00:00 2001 From: alxndrsn Date: Fri, 15 Mar 2024 09:20:19 +0000 Subject: [PATCH 2/4] ci: add node 18 & 20 to build matrix --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 757418f..d2b3c53 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -18,7 +18,7 @@ jobs: strategy: matrix: - node-version: [8.x, 10.x, 12.x, 14.x, 16.x] + node-version: [8.x, 10.x, 12.x, 14.x, 16.x, 18.x, 20.x] steps: - uses: actions/checkout@v3 From b44fa3449f0973455e52ce55aaed8e4538a626b1 Mon Sep 17 00:00:00 2001 From: alxndrsn Date: Fri, 15 Mar 2024 09:21:56 +0000 Subject: [PATCH 3/4] ci: drop node 8 Node 8 EOL'd a while ago, and breaks the build. Dropping suport seems simpler than fixing. --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index d2b3c53..a05d0e4 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -18,7 +18,7 @@ jobs: strategy: matrix: - node-version: [8.x, 10.x, 12.x, 14.x, 16.x, 18.x, 20.x] + node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x] steps: - uses: actions/checkout@v3 From 76911aa9eedb0d5267f8d07f3b4f5fec4df311e4 Mon Sep 17 00:00:00 2001 From: alxndrsn Date: Fri, 15 Mar 2024 09:22:16 +0000 Subject: [PATCH 4/4] ci: don't fail fast This allows all matrix builds to run, making it easier to understand if a given failure is specific to nodejs version(s), or more general. --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a05d0e4..94b0cb2 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -17,6 +17,7 @@ jobs: options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5 strategy: + fail-fast: false matrix: node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]