Skip to content

Commit c798176

Browse files
AbhiPrasadclaude
andauthored
revert: use npm in publish workflow instead of pnpm (#1452)
Reverts the publish-related changes from #1450 and #1451, restoring npm for the publish workflow and scripts while keeping the husky || true fix. pnpm publish has a ton of drawbacks compared to using plain npm. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent db96141 commit c798176

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

.github/workflows/publish-js-sdk.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,13 @@ jobs:
7272
- uses: actions/checkout@v4
7373
with:
7474
fetch-depth: 0 # Fetch all history for changelog generation
75-
- uses: pnpm/action-setup@v4
7675
- name: Set up Node.js
7776
uses: actions/setup-node@v4
7877
with:
7978
node-version: "20"
8079
registry-url: "https://registry.npmjs.org"
80+
- name: Install npm 11.6.2
81+
run: npm install -g npm@11.6.2
8182

8283
- name: Determine version
8384
id: set_version

js/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ verify-ci: build docs test
150150

151151
publish-sdk-js:
152152
./scripts/validate-release.sh
153-
pnpm install
154-
pnpm run build
155-
pnpm publish --no-git-checks --provenance
153+
npm install
154+
npm run build
155+
npm publish
156156

157157
# This is the only method I could find to install a package without explicitly
158158
# adding a dependency or modifying lock files.

js/scripts/publish-prerelease.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ echo ""
7474

7575
# Build the SDK
7676
echo "Building SDK..."
77-
pnpm install
78-
pnpm run build
77+
npm install
78+
npm run build
7979
echo "Build complete."
8080
echo ""
8181

@@ -87,13 +87,13 @@ echo ""
8787
# In CI, just publish. Locally, ask for confirmation
8888
if [ -n "${CI:-}" ] || [ -n "${GITHUB_ACTIONS:-}" ]; then
8989
# Running in CI - publish without confirmation
90-
pnpm publish --tag "$DIST_TAG" --no-git-checks --provenance
90+
npm publish --tag "$DIST_TAG"
9191
else
9292
# Running locally - ask for confirmation
9393
read -p "Ready to publish version $NEW_VERSION to npm with tag @$DIST_TAG? (y/N) " -n 1 -r
9494
echo
9595
if [[ $REPLY =~ ^[Yy]$ ]]; then
96-
pnpm publish --tag "$DIST_TAG" --no-git-checks
96+
npm publish --tag "$DIST_TAG"
9797
else
9898
echo "Publish cancelled."
9999
echo ""

0 commit comments

Comments
 (0)