Skip to content

fix: add scroll to new item dialog form #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asadlion11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add scroll to new item dialog form #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/items/new-item-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export default function NewItemDialog({ open, onOpenChange, defaultType, isPro }

return (
<Dialog open={open} onOpenChange={handleClose}>
<DialogContent className="sm:max-w-[500px]">
<DialogContent className="sm:max-w-[500px] flex flex-col max-h-[90vh]">
<DialogHeader>
<DialogTitle className="flex items-center gap-2">
{IconComponent && (
Expand All @@ -185,7 +185,8 @@ export default function NewItemDialog({ open, onOpenChange, defaultType, isPro }
</DialogTitle>
</DialogHeader>

<form onSubmit={handleSubmit} className="space-y-4">
<form onSubmit={handleSubmit} className="flex flex-col flex-1 min-h-0">
<div className="space-y-4 overflow-y-auto flex-1 pr-1">
<div className="space-y-2">
<Label htmlFor="type">Type</Label>
<Select value={typeName} onValueChange={(v) => setTypeName(v as ItemTypeName)}>
Expand Down Expand Up @@ -356,7 +357,9 @@ export default function NewItemDialog({ open, onOpenChange, defaultType, isPro }
</div>
)}

<div className="flex justify-end gap-3 pt-2">
</div>

<div className="flex justify-end gap-3 pt-4 mt-2 border-t border-border">
<Button
type="button"
variant="outline"
Expand Down