Incorrect rendering when combining diacritical marks

[grisha]

For example when using this font https://raw.githubusercontent.com/slavonic/Indiction/master/fonts/otf/Indiction-Regular.otf

To render a sequence "И҆́" we get incorrect:

whereas it should look like:

This is a bug in textshape and is fixed in boxesandglue/textshape#1

[pgundlach]

Can you check again? I have updated textshape, but I don't have a test case right now.

[grisha]

It's still broken, but in a different way:

I suspect you still need to merge this PR boxesandglue/textshape#1 and that will probably fix it.

[pgundlach]

Do you have a test file?

[grisha]

My bad - it is working fine now, I've gotten all tangled up in my branches, so maybe that boxesandglue/textshape#1 was/is not necessary after all.

But if you ever need a test case, here it is:

In an empty directory:

main.go:

package main

import (
    "log"

    "github.com/boxesandglue/boxesandglue/backend/bag"
    "github.com/boxesandglue/boxesandglue/frontend"
)

func main() {
    f, err := frontend.New("output.pdf")
    if err != nil {
        log.Fatal(err)
    }

    ff := f.NewFontFamily("indiction")
    ff.AddMember(
        &frontend.FontSource{Location: "Indiction-Regular.otf"},
        frontend.FontWeight400,
        frontend.FontStyleNormal,
    )

    p := f.Doc.NewPage()

    text := &frontend.Text{
        Settings: frontend.TypesettingSettings{
            frontend.SettingFontFamily: ff,
            frontend.SettingSize:       bag.MustSP("48pt"),
        },
        Items: []any{"И"}, // И + U+0486 (breathing mark) + U+0301 (accent)                                                                                                                                                                                    
    }
    vl, _, _ := f.FormatParagraph(text, bag.MustSP("80mm"))
    p.OutputAt(bag.MustSP("20mm"), bag.MustSP("200mm"), vl)

    p.Shipout()
    f.Doc.Finish()
}

wget https://raw.githubusercontent.com/slavonic/Indiction/master/fonts/otf/Indiction-Regular.otf
go mod init testcase                                                                                                         
go get github.com/boxesandglue/boxesandglue@latest                                                                                                                                                                                                           
go mod tidy                                                                                                                  
go run main.go 

[pgundlach]

Thank you very much. I guess it works now?

[grisha]

Thank you very much. I guess it works now?

yes, confirmed, thank you!

there is another PR on a different issue though :)