From a4c0996bee8efe36d51d9892cd93bdd707ea1fe5 Mon Sep 17 00:00:00 2001 From: David Bold Date: Fri, 28 Nov 2025 13:41:32 +0100 Subject: [PATCH 1/2] Do not unconditionally set file_cache_maxsize --- xbout/load.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xbout/load.py b/xbout/load.py index 6a8effd2..456aeda5 100644 --- a/xbout/load.py +++ b/xbout/load.py @@ -738,7 +738,7 @@ def _expand_filepaths(datapath): if not filepaths: raise IOError("No datafiles found matching datapath={}".format(datapath)) - if len(filepaths) > 128: + if len(filepaths) > xr.get_options().get("file_cache_maxsize", 128): warn( "Trying to open a large number of files - setting xarray's" " `file_cache_maxsize` global option to {} to accommodate this. " From 87d63f35cfa07253a304e8f0891dcafc56765d36 Mon Sep 17 00:00:00 2001 From: David Bold Date: Fri, 28 Nov 2025 13:41:55 +0100 Subject: [PATCH 2/2] Do not bother user about opening many files --- xbout/load.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xbout/load.py b/xbout/load.py index 456aeda5..82e0bcd6 100644 --- a/xbout/load.py +++ b/xbout/load.py @@ -739,14 +739,6 @@ def _expand_filepaths(datapath): raise IOError("No datafiles found matching datapath={}".format(datapath)) if len(filepaths) > xr.get_options().get("file_cache_maxsize", 128): - warn( - "Trying to open a large number of files - setting xarray's" - " `file_cache_maxsize` global option to {} to accommodate this. " - "Recommend using `xr.set_options(file_cache_maxsize=NUM)`" - " to explicitly set this to a large enough value.".format( - str(len(filepaths)) - ) - ) xr.set_options(file_cache_maxsize=len(filepaths)) return filepaths, filetype