fix(redis): clear stale schedule fields on upsert

Author: RomainLanz

src/drivers/redis_adapter.ts

@@ -703,6 +703,7 @@ export class RedisAdapter implements Adapter {
   async createSchedule(config: ScheduleConfig): Promise<string> {
     const id = config.id ?? randomUUID()
     const now = Date.now()
+    const scheduleKey = `${schedulesKey}::${id}`
 
     const scheduleData: Record<string, string> = {
       id,
@@ -714,18 +715,19 @@ export class RedisAdapter implements Adapter {
       created_at: now.toString(),
     }
 
-    if (config.cronExpression) scheduleData.cron_expression = config.cronExpression
-    if (config.everyMs) scheduleData.every_ms = config.everyMs.toString()
-    if (config.from) scheduleData.from_date = config.from.getTime().toString()
-    if (config.to) scheduleData.to_date = config.to.getTime().toString()
-    if (config.limit) scheduleData.run_limit = config.limit.toString()
-
-    // Store schedule as hash
-    const scheduleKey = `${schedulesKey}::${id}`
-    await this.#connection.hset(scheduleKey, scheduleData)
-
-    // Add to index set for listing
-    await this.#connection.sadd(schedulesIndexKey, id)
+    if (config.cronExpression !== undefined) scheduleData.cron_expression = config.cronExpression
+    if (config.everyMs !== undefined) scheduleData.every_ms = config.everyMs.toString()
+    if (config.from !== undefined) scheduleData.from_date = config.from.getTime().toString()
+    if (config.to !== undefined) scheduleData.to_date = config.to.getTime().toString()
+    if (config.limit !== undefined) scheduleData.run_limit = config.limit.toString()
+
+    // Upsert schedule and clear stale optional fields from previous config.
+    await this.#connection
+      .multi()
+      .hdel(scheduleKey, 'cron_expression', 'every_ms', 'from_date', 'to_date', 'run_limit')
+      .hset(scheduleKey, scheduleData)
+      .sadd(schedulesIndexKey, id)
+      .exec()
 
     return id
   }

tests/_utils/register_driver_test_suite.ts

@@ -1132,6 +1132,41 @@ export function registerDriverTestSuite(options: DriverTestSuiteOptions) {
     assert.equal(schedule!.timezone, 'Europe/Paris')
   })
 
+  test('createSchedule upsert should clear stale scheduling fields', async ({ assert }) => {
+    const adapter = await options.createAdapter()
+
+    const from = new Date('2024-01-01T00:00:00.000Z')
+    const to = new Date('2024-12-31T23:59:59.999Z')
+
+    await adapter.createSchedule({
+      id: 'upsert-stale-fields',
+      name: 'TestJob',
+      payload: { version: 1 },
+      cronExpression: '0 0 * * *',
+      timezone: 'UTC',
+      from,
+      to,
+      limit: 10,
+    })
+
+    await adapter.createSchedule({
+      id: 'upsert-stale-fields',
+      name: 'TestJob',
+      payload: { version: 2 },
+      everyMs: 30000,
+      timezone: 'UTC',
+    })
+
+    const schedule = await adapter.getSchedule('upsert-stale-fields')
+    assert.isNotNull(schedule)
+    assert.deepEqual(schedule!.payload, { version: 2 })
+    assert.equal(schedule!.everyMs, 30000)
+    assert.isNull(schedule!.cronExpression)
+    assert.isNull(schedule!.from)
+    assert.isNull(schedule!.to)
+    assert.isNull(schedule!.limit)
+  })
+
   test('getSchedule should return null for non-existent schedule', async ({ assert }) => {
     const adapter = await options.createAdapter()