Use more efficient strings.NewReader

Author: riobard

virtualbox/dhcp.go

@@ -2,8 +2,8 @@ package virtualbox
 
 import (
 	"bufio"
-	"bytes"
 	"net"
+	"strings"
 )
 
 // DHCP server info.
@@ -47,7 +47,7 @@ func DHCPs() (map[string]*DHCP, error) {
 	if err != nil {
 		return nil, err
 	}
-	s := bufio.NewScanner(bytes.NewReader([]byte(out)))
+	s := bufio.NewScanner(strings.NewReader(out))
 	m := map[string]*DHCP{}
 	dhcp := &DHCP{}
 	for s.Scan() {

virtualbox/hostonlynet.go

@@ -2,12 +2,12 @@ package virtualbox
 
 import (
 	"bufio"
-	"bytes"
 	"errors"
 	"fmt"
 	"net"
 	"regexp"
 	"strconv"
+	"strings"
 )
 
 var (
@@ -72,7 +72,7 @@ func HostonlyNets() (map[string]*HostonlyNet, error) {
 	if err != nil {
 		return nil, err
 	}
-	s := bufio.NewScanner(bytes.NewReader([]byte(out)))
+	s := bufio.NewScanner(strings.NewReader(out))
 	m := map[string]*HostonlyNet{}
 	n := &HostonlyNet{}
 	for s.Scan() {

virtualbox/machine.go

@@ -2,10 +2,10 @@ package virtualbox
 
 import (
 	"bufio"
-	"bytes"
 	"fmt"
 	"path/filepath"
 	"strconv"
+	"strings"
 	"time"
 )
 
@@ -189,7 +189,7 @@ func GetMachine(id string) (*Machine, error) {
 		}
 		return nil, err
 	}
-	s := bufio.NewScanner(bytes.NewReader([]byte(stdout)))
+	s := bufio.NewScanner(strings.NewReader(stdout))
 	m := &Machine{}
 	for s.Scan() {
 		res := reVMInfoLine.FindStringSubmatch(s.Text())
@@ -248,7 +248,7 @@ func ListMachines() ([]*Machine, error) {
 		return nil, err
 	}
 	ms := []*Machine{}
-	s := bufio.NewScanner(bytes.NewReader([]byte(out)))
+	s := bufio.NewScanner(strings.NewReader(out))
 	for s.Scan() {
 		res := reVMNameUUID.FindStringSubmatch(s.Text())
 		if res == nil {

virtualbox/natnet.go

@@ -2,9 +2,9 @@ package virtualbox
 
 import (
 	"bufio"
-	"bytes"
 	"net"
 	"strconv"
+	"strings"
 )
 
 // A NATNet defines a NAT network.
@@ -22,7 +22,7 @@ func NATNets() (map[string]NATNet, error) {
 	if err != nil {
 		return nil, err
 	}
-	s := bufio.NewScanner(bytes.NewReader([]byte(out)))
+	s := bufio.NewScanner(strings.NewReader(out))
 	m := map[string]NATNet{}
 	n := NATNet{}
 	for s.Scan() {