Script module is now failing with errors

[kinggrowler]

The updated script module from 515 is failing my scripts with multiple errors.

============================ Start 'script' Module ============================
Running script: /tmp/files/scripts/01-base-main.sh
Error: nu::shell::eval_block_with_input

  × Eval block failed with pipeline input
   ╭─[/tmp/modules/script/script.nu:5:7]
 4 │   let config = $config
 5 │     | from json
   ·       ────┬────
   ·           ╰── source value
 6 │     | default [] scripts
   ╰────

Error: nu::shell::io::uncategorized_error

  × I/O error
  ╰─▶   × Could not spawn foreground child: Exec format error (os error
        │ 8)

   ╭────
 1 │ crates/nu-command/src/system/run_external.rs:279:49
   · ─────────────────────────┬─────────────────────────
   ·                          ╰── Uncategorized error
   ╰────

============================ Failed 'script' Module ============================

This script ran until the recent update.

For completeness, this is the script the module is failing on:

#!/usr/bin/env bash
set -xeuo pipefail

source /usr/lib/os-release

if [[ "$ID" == "fedora" && "$VERSION_ID" -ge 43 ]]; then
layout=ostree" | tee /usr/lib/kernel/install.conf > /dev/null
fi

if [ -d "/usr/share/dnf5/libdnf.conf.d/" ]; then
  echo -e "[main]\ninstallonlypkgs=''" | tee /usr/share/dnf5/libdnf.conf.d/20-ostree-installonlypkgs.conf
else
  echo "installonlypkgs=''" >> /etc/dnf/dnf.conf
fi

This is how the script module is called from my recipe:

  - type: script
    scripts:
      - 01-base-main.sh
      - 02-base-packages.sh
      - 10-core.sh
      - 11-bootupd.sh
      - 12-initramfs.sh
      - 13-sysroot-ro.sh
      - 14-composefs.sh
      - 95-sanity-check.sh

Is it possible to roll-back this change on my end? Something like adding a source line at the top of the script-module block, like so:

source: ghcr.io/blue-build/modules:

Or do I have to re-write all my scripts for sh instead of bash? That will be a lot of work...

[gmpinder]

You can roll back with type: script@v1 if you want. Though I'm curious as to why this stopped working for you. My builds aren't having this problem. The shebang should make it use bash. It would help if you linked your repo.

[kinggrowler]

Sure, the repo is my xfce-atomic build, a heavily altered version of Fedora atomic "xfce-atomic" from Fedora Ostree ci-test which I tweaked to make work with the blue-build system. It uses ci-test "base-atomic" as the base image, and attempts to recreate as faithfully as possible their "xfce-atomic" image (in case it disappears someday).

I rewrote all my scripts to use sh, but the scripts module failed with the same error. I have since rolled-back to the earlier commit so you can see where it started to fail.

[gmpinder]

Try making sure your shebang is on the first line for all of your scripts.

[kinggrowler]

Try making sure your shebang is on the first line for all of your scripts.

Yes, that works. I had copied these scripts nearly whole-cloth from upstream Fedora ci-test recipes for xfce-atomic, but nearly all had been embedded in yaml files for their build process. I "unyaml'd" them, and everything worked great for v1 of the scripts module. so I didn't bother to sanitize further. Thanks for getting me back on track.