Merge pull request #52 from blocknotes/chore/address-rubocop-offenses

Address Rubocop offenses

Author: blocknotes

.rubocop.yml

@@ -10,6 +10,7 @@ plugins:
 AllCops:
   Exclude:
     - bin/*
+    - extra/**/*
     - spec/dummy_rails/**/*
     - vendor/**/*
   NewCops: enable

extra/sample_features_app/admin/items.rb

@@ -12,8 +12,8 @@ module Admin
 
   class ItemsRepo < ::TinyAdmin::Plugins::BaseRepository
     def fields(options: nil)
-      COLUMNS.each_with_object({}) do |name, result|
-        result[name] = TinyAdmin::Field.create_field(name: name)
+      COLUMNS.to_h do |name|
+        [name, TinyAdmin::Field.create_field(name: name)]
       end
     end
 
@@ -28,7 +28,7 @@ def index_title
     def list(page: 1, limit: 10, filters: nil, sort: ['id'])
       page_offset = page.positive? ? (page - 1) * limit : 0
       [
-        RECORDS[page_offset...page_offset + limit],
+        RECORDS[page_offset...(page_offset + limit)],
         RECORDS.size
       ]
     end

lib/tiny_admin/actions/index.rb

@@ -51,8 +51,8 @@ def evaluate_options(options)
 
       def prepare_filters(fields)
         filters = (options[:filters] || []).map { _1.is_a?(Hash) ? _1 : { field: _1 } }
-        filters = filters.each_with_object({}) { |filter, result| result[filter[:field]] = filter }
-        values = (params['q'] || {})
+        filters = filters.to_h { |filter| [filter[:field], filter] }
+        values = params['q'] || {}
         fields.each_with_object({}) do |(name, field), result|
           result[field] = { value: values[name], filter: filters[name] } if filters.key?(name)
         end

lib/tiny_admin/plugins/base_repository.rb

@@ -3,7 +3,8 @@
 module TinyAdmin
   module Plugins
     class BaseRepository
-      RecordNotFound = Class.new(StandardError)
+      class RecordNotFound < StandardError
+      end
 
       attr_reader :model
 

lib/tiny_admin/plugins/no_auth.rb

@@ -8,7 +8,7 @@ def configure(_app, _opts = {}); end
       end
 
       module InstanceMethods
-        def authenticate_user!
+        def authenticate_user! # rubocop:disable Naming/PredicateMethod
           true
         end
 

lib/tiny_admin/views/components/pagination.rb

@@ -22,7 +22,7 @@ def view_template
                       pages_range((current > pages - 4 ? current - 2 : pages - 2)..pages)
                     else
                       pages_range(1..1, with_dots: true)
-                      pages_range(current - 2..current + 2, with_dots: true)
+                      pages_range((current - 2)..(current + 2), with_dots: true)
                       pages_range(pages..pages)
                     end
                   }

spec/lib/tiny_admin/actions/basic_action_spec.rb

@@ -11,35 +11,36 @@
     it "handles simple string field names" do
       result = action.attribute_options(["id", "name"])
       expect(result).to eq(
-        "id" => {field: "id"},
-        "name" => {field: "name"}
+        "id" => { field: "id" },
+        "name" => { field: "name" }
       )
     end
 
     it "handles single-entry hash with method shorthand" do
-      result = action.attribute_options([{title: "downcase, capitalize"}])
+      result = action.attribute_options([{ title: "downcase, capitalize" }])
       expect(result).to eq(
-        "title" => {field: "title", method: "downcase, capitalize"}
+        "title" => { field: "title", method: "downcase, capitalize" }
       )
     end
 
     it "handles multi-entry hash with explicit field key" do
-      result = action.attribute_options([{field: "author_id", link_to: "authors"}])
+      result = action.attribute_options([{ field: "author_id", link_to: "authors" }])
       expect(result).to eq(
-        "author_id" => {field: "author_id", link_to: "authors"}
+        "author_id" => { field: "author_id", link_to: "authors" }
       )
     end
 
     it "handles mixed input types" do
-      result = action.attribute_options([
+      opts = [
         "id",
-        {title: "upcase"},
-        {field: "created_at", method: "strftime, %Y-%m-%d"}
-      ])
+        { title: "upcase" },
+        { field: "created_at", method: "strftime, %Y-%m-%d" }
+      ]
+      result = action.attribute_options(opts)
       expect(result).to eq(
-        "id" => {field: "id"},
-        "title" => {field: "title", method: "upcase"},
-        "created_at" => {field: "created_at", method: "strftime, %Y-%m-%d"}
+        "id" => { field: "id" },
+        "title" => { field: "title", method: "upcase" },
+        "created_at" => { field: "created_at", method: "strftime, %Y-%m-%d" }
       )
     end
   end

spec/lib/tiny_admin/field_spec.rb

@@ -21,7 +21,7 @@
     end
 
     it "uses the provided options when given" do
-      options = {method: "downcase"}
+      options = { method: "downcase" }
       field = described_class.create_field(name: "name", options: options)
       expect(field.options).to eq(options)
     end
@@ -39,7 +39,7 @@
 
   describe "#apply_call_option" do
     it "chains method calls on the target" do
-      field = described_class.new(name: "title", title: "Title", type: :string, options: {call: "to_s, downcase"})
+      field = described_class.new(name: "title", title: "Title", type: :string, options: { call: "to_s, downcase" })
       expect(field.apply_call_option(42)).to eq("42")
     end
 
@@ -49,7 +49,7 @@
     end
 
     it "handles nil target safely via safe navigation" do
-      field = described_class.new(name: "title", title: "Title", type: :string, options: {call: "nonexistent"})
+      field = described_class.new(name: "title", title: "Title", type: :string, options: { call: "nonexistent" })
       expect(field.apply_call_option(nil)).to be_nil
     end
   end
@@ -66,7 +66,7 @@
     end
 
     it "applies the helper method from options" do
-      field = described_class.new(name: "name", title: "Name", type: :string, options: {method: "downcase"})
+      field = described_class.new(name: "name", title: "Name", type: :string, options: { method: "downcase" })
       allow(TinyAdmin.settings).to receive(:helper_class).and_return(TinyAdmin::Support)
       expect(field.translate_value("HELLO")).to eq("hello")
     end
@@ -81,15 +81,15 @@ def self.upcase(value, options: [])
 
       field = described_class.new(
         name: "name", title: "Name", type: :string,
-        options: {method: "upcase", converter: "TestConverter"}
+        options: { method: "upcase", converter: "TestConverter" }
       )
       expect(field.translate_value("hello")).to eq("HELLO")
     end
 
     it "passes additional args to the method" do
       field = described_class.new(
         name: "value", title: "Value", type: :float,
-        options: {method: "round, 1"}
+        options: { method: "round, 1" }
       )
       allow(TinyAdmin.settings).to receive(:helper_class).and_return(TinyAdmin::Support)
       expect(field.translate_value(3.456)).to eq(3.5)

spec/lib/tiny_admin/plugins/active_record_repository_spec.rb

@@ -31,7 +31,7 @@
     end
 
     it "returns only specified fields when options given" do
-      options = {"name" => {}, "email" => {}}
+      options = { "name" => {}, "email" => {} }
       fields = repository.fields(options: options)
       expect(fields.keys).to eq(["name", "email"])
     end
@@ -72,7 +72,7 @@
     end
 
     it "returns only specified fields when fields given", :aggregate_failures do
-      attrs = repository.index_record_attrs(author, fields: {"name" => nil, "email" => nil})
+      attrs = repository.index_record_attrs(author, fields: { "name" => nil, "email" => nil })
       expect(attrs.keys).to eq(["name", "email"])
       expect(attrs["name"]).to eq(author.name)
     end
@@ -93,7 +93,7 @@
     end
 
     it "sorts when sort option given" do
-      records, = repository.list(page: 1, limit: 10, sort: {name: :desc})
+      records, = repository.list(page: 1, limit: 10, sort: { name: :desc })
       names = records.map(&:name)
       expect(names).to eq(names.sort.reverse)
     end
@@ -104,7 +104,7 @@
 
     it "filters string fields with LIKE" do
       title_field = TinyAdmin::Field.new(name: "title", title: "Title", type: :string)
-      filters = {title_field => {value: "post 1"}}
+      filters = { title_field => { value: "post 1" } }
       results = post_repository.apply_filters(Post.all, filters)
       results.each do |post|
         expect(post.title.downcase).to include("post 1")
@@ -114,7 +114,7 @@
     it "filters non-string fields with equality" do
       author = Author.first
       author_field = TinyAdmin::Field.new(name: "author_id", title: "Author", type: :integer)
-      filters = {author_field => {value: author.id}}
+      filters = { author_field => { value: author.id } }
       results = post_repository.apply_filters(Post.all, filters)
       results.each do |post|
         expect(post.author_id).to eq(author.id)
@@ -123,14 +123,14 @@
 
     it "skips filters with nil or empty values" do
       title_field = TinyAdmin::Field.new(name: "title", title: "Title", type: :string)
-      filters = {title_field => {value: nil}}
+      filters = { title_field => { value: nil } }
       results = post_repository.apply_filters(Post.all, filters)
       expect(results.count).to eq(Post.count)
     end
 
     it "sanitizes SQL LIKE input" do
       title_field = TinyAdmin::Field.new(name: "title", title: "Title", type: :string)
-      filters = {title_field => {value: "100%"}}
+      filters = { title_field => { value: "100%" } }
       # Should not raise or cause SQL injection
       expect { post_repository.apply_filters(Post.all, filters).to_a }.not_to raise_error
     end

spec/lib/tiny_admin/route_for_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe "TinyAdmin.route_for" do
+RSpec.describe "TinyAdmin.route_for" do # rubocop:disable RSpec/DescribeClass
   before do
     allow(TinyAdmin.settings).to receive(:root_path).and_return("/admin")
   end