Merge pull request #56 from blocknotes/switch-to-double-quotes-for-strings

Switch to double quotes for strings

Author: blocknotes

.rubocop.yml

@@ -33,3 +33,7 @@ Style/ExplicitBlockArgument:
 Style/GuardClause:
   Exclude:
     - lib/tiny_admin/router.rb
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes

Gemfile

@@ -1,34 +1,34 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gemspec
 
 group :development, :test do
-  gem 'rails', '~> 7.1'
+  gem "rails", "~> 7.1"
 
-  gem 'sqlite3', '< 2.0'
-  gem 'tilt'
-  gem 'warden'
-  gem 'webrick'
+  gem "sqlite3", "< 2.0"
+  gem "tilt"
+  gem "warden"
+  gem "webrick"
 
-  gem 'rbs'
+  gem "rbs"
 
   # Testing
-  gem 'capybara'
-  gem 'capybara-screenshot'
-  gem 'rspec-rails'
-  gem 'simplecov', require: false
+  gem "capybara"
+  gem "capybara-screenshot"
+  gem "rspec-rails"
+  gem "simplecov", require: false
 
   # Linters
   # gem 'fasterer'
-  gem 'rubocop'
-  gem 'rubocop-packaging'
-  gem 'rubocop-performance'
-  gem 'rubocop-rspec'
+  gem "rubocop"
+  gem "rubocop-packaging"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
 
   # Tools
   # gem 'overcommit', '~> 0.59'
-  gem 'pry-rails'
+  gem "pry-rails"
 end

lib/tiny_admin.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require 'phlex'
-require 'roda'
-require 'zeitwerk'
+require "phlex"
+require "roda"
+require "zeitwerk"
 
-require 'forwardable'
-require 'singleton'
-require 'yaml'
+require "forwardable"
+require "singleton"
+require "yaml"
 
 loader = Zeitwerk::Loader.for_gem
 loader.setup
@@ -25,10 +25,10 @@ def configure_from_file(file)
   end
 
   def route_for(section, reference: nil, action: nil, query: nil)
-    root_path = settings.root_path == '/' ? nil : settings.root_path
+    root_path = settings.root_path == "/" ? nil : settings.root_path
     route = [root_path, section, reference, action].compact.join("/")
     route << "?#{query}" if query
-    route[0] == '/' ? route : route.prepend('/')
+    route[0] == "/" ? route : route.prepend("/")
   end
 
   def settings

lib/tiny_admin/actions/index.rb

@@ -45,14 +45,14 @@ def evaluate_options(options)
         @params = context.request.params
         @repository = context.repository
         @pagination = options[:pagination] || 10
-        @current_page = (params['p'] || 1).to_i
-        @query_string = params_to_s(params.except('p'))
+        @current_page = (params["p"] || 1).to_i
+        @query_string = params_to_s(params.except("p"))
       end
 
       def prepare_filters(fields)
         filters = (options[:filters] || []).map { _1.is_a?(Hash) ? _1 : { field: _1 } }
         filters = filters.to_h { |filter| [filter[:field], filter] }
-        values = params['q'] || {}
+        values = params["q"] || {}
         fields.each_with_object({}) do |(name, field), result|
           result[field] = { value: values[name], filter: filters[name] } if filters.key?(name)
         end

lib/tiny_admin/authentication.rb

@@ -3,23 +3,23 @@
 module TinyAdmin
   class Authentication < BasicApp
     route do |r|
-      r.get 'unauthenticated' do
+      r.get "unauthenticated" do
         if current_user
           r.redirect TinyAdmin.settings.root_path
         else
           render_login
         end
       end
 
-      r.post 'unauthenticated' do
+      r.post "unauthenticated" do
         warning = TinyAdmin.settings.helper_class.label_for(
-          'Failed to authenticate',
-          options: ['authentication.unauthenticated']
+          "Failed to authenticate",
+          options: ["authentication.unauthenticated"]
         )
         render_login(warnings: [warning])
       end
 
-      r.get 'logout' do
+      r.get "logout" do
         logout_user
         r.redirect TinyAdmin.settings.root_path
       end
@@ -33,9 +33,9 @@ def render_login(notices: nil, warnings: nil, errors: nil)
 
       page = prepare_page(login, options: %i[no_menu compact_layout])
       page.messages = {
-        notices: notices || flash['notices'],
-        warnings: warnings || flash['warnings'],
-        errors: errors || flash['errors']
+        notices: notices || flash["notices"],
+        warnings: warnings || flash["warnings"],
+        errors: errors || flash["errors"]
       }
       render(inline: page.call)
     end

lib/tiny_admin/basic_app.rb

@@ -14,7 +14,7 @@ def authentication_plugin
 
     plugin :flash
     plugin :not_found
-    plugin :render, engine: 'html'
+    plugin :render, engine: "html"
     plugin :sessions, secret: SecureRandom.hex(64)
 
     plugin authentication_plugin, TinyAdmin.settings.authentication

lib/tiny_admin/field.rb

@@ -12,13 +12,13 @@ def initialize(name:, title:, type:, options: {})
     end
 
     def apply_call_option(target)
-      messages = (options[:call] || '').split(',').map(&:strip)
+      messages = (options[:call] || "").split(",").map(&:strip)
       messages.inject(target) { |result, msg| result&.send(msg) } if messages.any?
     end
 
     def translate_value(value)
       if options && options[:method]
-        method, *args = options[:method].split(',').map(&:strip)
+        method, *args = options[:method].split(",").map(&:strip)
         if options[:converter]
           Object.const_get(options[:converter]).send(method, value, options: args || [])
         else
@@ -32,7 +32,7 @@ def translate_value(value)
     class << self
       def create_field(name:, title: nil, type: nil, options: {})
         field_name = name.to_s
-        field_title = field_name.respond_to?(:humanize) ? field_name.humanize : field_name.tr('_', ' ').capitalize
+        field_title = field_name.respond_to?(:humanize) ? field_name.humanize : field_name.tr("_", " ").capitalize
         new(name: field_name, title: title || field_title, type: type || :string, options: options || {})
       end
     end

lib/tiny_admin/plugins/active_record_repository.rb

@@ -54,7 +54,7 @@ def list(page: 1, limit: 10, sort: nil, filters: nil)
       def apply_filters(query, filters)
         filters.each do |field, filter|
           value = filter&.dig(:value)
-          next if value.nil? || value == ''
+          next if value.nil? || value == ""
 
           query =
             case field.type

lib/tiny_admin/plugins/no_auth.rb

@@ -13,7 +13,7 @@ def authenticate_user! # rubocop:disable Naming/PredicateMethod
         end
 
         def current_user
-          'admin'
+          "admin"
         end
 
         def logout_user

lib/tiny_admin/plugins/simple_auth.rb

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
 
-require 'digest'
+require "digest"
 
 module TinyAdmin
   module Plugins
     module SimpleAuth
       class << self
         def configure(app, opts = {})
           @@opts = opts || {} # rubocop:disable Style/ClassVars
-          @@opts[:password] ||= ENV.fetch('ADMIN_PASSWORD_HASH', nil) # NOTE: fallback value
+          @@opts[:password] ||= ENV.fetch("ADMIN_PASSWORD_HASH", nil) # NOTE: fallback value
 
           Warden::Strategies.add(:secret) do
             def authenticate!
-              secret = params['secret'] || ''
+              secret = params["secret"] || ""
               return fail(:invalid_credentials) if Digest::SHA512.hexdigest(secret) != @@opts[:password]
 
-              success!(app: 'TinyAdmin')
+              success!(app: "TinyAdmin")
             end
           end
 
@@ -29,15 +29,15 @@ def authenticate!
 
       module InstanceMethods
         def authenticate_user!
-          env['warden'].authenticate!
+          env["warden"].authenticate!
         end
 
         def current_user
-          env['warden'].user
+          env["warden"].user
         end
 
         def logout_user
-          env['warden'].logout
+          env["warden"].logout
         end
       end
     end