From c7fa0d065ef67e9ff86c3836a5d4d956e7a047e4 Mon Sep 17 00:00:00 2001 From: Elizabeth Worstell Date: Fri, 20 Mar 2026 08:45:48 -0700 Subject: [PATCH] fix(git): resolve data race in TestRepackInterval assert.NotZero uses repr to deep-reflect over the entire Strategy struct, which races with HTTP transport goroutines spawned during git.New. Replace with a simple nil check since the test only needs to verify non-nil return. Amp-Thread-ID: https://ampcode.com/threads/T-019d0be9-cfd7-72bf-9bbb-4a70965214f6 Co-authored-by: Amp --- internal/strategy/git/repack_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/strategy/git/repack_test.go b/internal/strategy/git/repack_test.go index f77e1d6..4ab7111 100644 --- a/internal/strategy/git/repack_test.go +++ b/internal/strategy/git/repack_test.go @@ -43,7 +43,7 @@ func TestRepackInterval(t *testing.T) { RepackInterval: tt.repackInterval, }, newTestScheduler(ctx, t), nil, mux, cm, func() (*githubapp.TokenManager, error) { return nil, nil }) //nolint:nilnil assert.NoError(t, err) - assert.NotZero(t, s) + assert.True(t, s != nil) }) } } @@ -67,5 +67,5 @@ func TestRepackScheduledForExistingRepos(t *testing.T) { RepackInterval: 24 * time.Hour, }, newTestScheduler(ctx, t), nil, mux, cm, func() (*githubapp.TokenManager, error) { return nil, nil }) //nolint:nilnil assert.NoError(t, err) - assert.NotZero(t, s) + assert.True(t, s != nil) }