Reject requests targeting a cachew playpen when not running as one

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d0345-d564-743f-ad25-f1063ade61da

Author: jrobotham-square

.bk.yaml

@@ -0,0 +1 @@
+selected_org: cash

cmd/cachewd/main.go

@@ -214,6 +214,9 @@ func newServer(ctx context.Context, muxHandler http.Handler, bind string, metric
 	)(handler)
 
 	handler = httputil.LoggingMiddleware(handler)
+	if os.Getenv("IS_PLAYPEN") != "true" {
+		handler = httputil.PlaypenGuardMiddleware(handler)
+	}
 
 	logger := logging.FromContext(ctx)
 	return &http.Server{

internal/httputil/playpen_guard.go

@@ -0,0 +1,31 @@
+package httputil
+
+import (
+	"net/http"
+	"strings"
+)
+
+// PlaypenGuardMiddleware rejects requests that target a playpen instance
+// (via the Baggage header) when this instance is not a playpen.
+// This prevents requests from silently falling through to staging.
+func PlaypenGuardMiddleware(next http.Handler) http.Handler {
+	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		if baggage := r.Header.Get("Baggage"); hasCachewPlaypenKey(baggage) {
+			http.Error(w, "no matching cachew playpen found — start one with: sq playpen sync", http.StatusServiceUnavailable)
+			return
+		}
+		next.ServeHTTP(w, r)
+	})
+}
+
+func hasCachewPlaypenKey(baggage string) bool {
+	if baggage == "" {
+		return false
+	}
+	for entry := range strings.SplitSeq(baggage, ",") {
+		if strings.HasPrefix(strings.TrimSpace(entry), "cachew-playpen=") {
+			return true
+		}
+	}
+	return false
+}

internal/httputil/playpen_guard_test.go

@@ -0,0 +1,41 @@
+package httputil_test
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/alecthomas/assert/v2"
+
+	"github.com/block/cachew/internal/httputil"
+)
+
+func TestPlaypenGuardMiddleware(t *testing.T) {
+	ok := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+		w.WriteHeader(http.StatusOK)
+	})
+	guard := httputil.PlaypenGuardMiddleware(ok)
+
+	t.Run("allows normal requests", func(t *testing.T) {
+		req := httptest.NewRequest(http.MethodGet, "/", nil)
+		rr := httptest.NewRecorder()
+		guard.ServeHTTP(rr, req)
+		assert.Equal(t, http.StatusOK, rr.Code)
+	})
+
+	t.Run("blocks requests with cachew playpen baggage", func(t *testing.T) {
+		req := httptest.NewRequest(http.MethodGet, "/", nil)
+		req.Header.Set("Baggage", "cachew-playpen=jrobotham")
+		rr := httptest.NewRecorder()
+		guard.ServeHTTP(rr, req)
+		assert.Equal(t, http.StatusServiceUnavailable, rr.Code)
+	})
+
+	t.Run("allows requests with unrelated baggage", func(t *testing.T) {
+		req := httptest.NewRequest(http.MethodGet, "/", nil)
+		req.Header.Set("Baggage", "blox-playpen=jrobotham")
+		rr := httptest.NewRecorder()
+		guard.ServeHTTP(rr, req)
+		assert.Equal(t, http.StatusOK, rr.Code)
+	})
+}