Skip to content

Commit 80643b3

Browse files
fix: resolve data race in TestRepackInterval (#208)
## Problem `TestRepackInterval/Enabled` has a data race between `assert.NotZero` (which uses `repr` to deep-reflect over the entire `*git.Strategy` struct) and HTTP transport goroutines spawned during `git.New`. ## Fix Replace `assert.NotZero(t, s)` with `assert.True(t, s != nil)` — the test only needs to verify a non-nil return, so deep reflection is unnecessary. Co-authored-by: Amp <amp@ampcode.com>
1 parent b6567eb commit 80643b3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

internal/strategy/git/repack_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func TestRepackInterval(t *testing.T) {
4343
RepackInterval: tt.repackInterval,
4444
}, newTestScheduler(ctx, t), nil, mux, cm, func() (*githubapp.TokenManager, error) { return nil, nil }) //nolint:nilnil
4545
assert.NoError(t, err)
46-
assert.NotZero(t, s)
46+
assert.True(t, s != nil)
4747
})
4848
}
4949
}
@@ -67,5 +67,5 @@ func TestRepackScheduledForExistingRepos(t *testing.T) {
6767
RepackInterval: 24 * time.Hour,
6868
}, newTestScheduler(ctx, t), nil, mux, cm, func() (*githubapp.TokenManager, error) { return nil, nil }) //nolint:nilnil
6969
assert.NoError(t, err)
70-
assert.NotZero(t, s)
70+
assert.True(t, s != nil)
7171
}

0 commit comments

Comments
 (0)