From 31ae17dc5fd51e7d82d5b12b8912c9496bf1b4c8 Mon Sep 17 00:00:00 2001 From: masterisk Date: Wed, 7 May 2025 20:10:09 +0900 Subject: [PATCH 1/2] Fixed character removal when artist joinphrase is set to the end --- lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb b/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb index d6945168..4b58816e 100644 --- a/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb +++ b/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb @@ -164,7 +164,7 @@ def analyzeResult # ' / ' is default separator artist << (credit.attributes['joinphrase'] || ' / ') end - artist = artist[0..-4] + artist = artist[0..-4] if artist.end_with?(' / ') varArtist[track.elements['position'].text.to_i] = artist end # extraDiscInfo => [Depends. What do you want?] From 675fd2ac448deaf8ab0bf6f9333c21af933c434e Mon Sep 17 00:00:00 2001 From: masterisk Date: Wed, 6 Aug 2025 21:11:38 +0900 Subject: [PATCH 2/2] fix remaining issue with artist name --- lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb b/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb index 4b58816e..789004f6 100644 --- a/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb +++ b/lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb @@ -129,7 +129,7 @@ def analyzeResult variousArtists = true end end - @md.artist = @md.artist[0..-4] + @md.artist = @md.artist[0..-4] if @md.artist.end_with?(' / ') if @musicbrainzRelease.elements['title'] and @musicbrainzRelease.elements['title'].text @md.album = @musicbrainzRelease.elements['title'].text end