Skip to content

[BWS] Ref: Transak accessToken is now required from frontend #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gamboster wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −28
Open

[BWS] Ref: Transak accessToken is now required from frontend #4182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 5 additions & 28 deletions packages/bitcore-wallet-service/src/externalservices/transak.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ export class TransakService {
transakGetSignedPaymentUrl(req): Promise<{ urlWithSignature: string }> {
return new Promise(async (resolve, reject) => {
const appRequiredParams = [
'accessToken',
'walletAddress',
'redirectURL',
'fiatAmount',
Expand All @@ -207,7 +208,7 @@ export class TransakService {
'partnerCustomerId',
];

const requiredParams = req.body.context === 'web' ? [] : appRequiredParams;
const requiredParams = req.body.context === 'web' ? ['accessToken'] : appRequiredParams;
const referrerDomain = req.body.referrerDomain ?? req.body.context === 'web' ? 'bitpay.com' : 'bitpay';
let keys;
try {
Expand All @@ -222,22 +223,10 @@ export class TransakService {
return reject(new ClientError("Transak's request missing arguments"));
}

let accessToken;
if (req.body.accessToken) {
accessToken = req.body.accessToken;
} else {
try {
const accessTokenData = await this.transakGetAccessToken(req);
accessToken = accessTokenData?.data?.accessToken;
} catch (err) {
return reject(err?.body ? err.body : err);
}
}

const headers = {
Accept: 'application/json',
'Content-Type': 'application/json',
'access-token': accessToken,
'access-token': req.body.accessToken,
};

const body = {
Expand Down Expand Up @@ -278,25 +267,13 @@ export class TransakService {
}
const API = keys.API;

if (!checkRequired(req.body, ['orderId'])) {
if (!checkRequired(req.body, ['orderId', 'accessToken'])) {
return reject(new ClientError("Transak's request missing arguments"));
}

let accessToken;
if (req.body.accessToken) {
accessToken = req.body.accessToken;
} else {
try {
const accessTokenData = await this.transakGetAccessToken(req);
accessToken = accessTokenData?.data?.accessToken;
} catch (err) {
return reject(err?.body ? err.body : err);
}
}

const headers = {
Accept: 'application/json',
'access-token': accessToken,
'access-token': req.body.accessToken,
};

const URL: string = API + `/partners/api/v2/order/${req.body.orderId}`;
Expand Down