-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Description
-
var_int.valuevsvar_str.strvsvar_list.list -
net_addr.addrsvsinv.inventoryvserror.vector -
pubkey.neededvsmsg.identitiesvsbroadcast.subscriptions -
bootstrap/connect/listenAPI: it's better to always use objects instead of positional arguments. (E.g.{host: "1.2.3.4", port: 8444}) -
connectionpass 3 positional arguments (should it passtransport, {host, port}instead?) - error message
fatalfield is nonintuitive (better to use something liketype) - version message
versionfield is nonintuitive (better to use something likeprotoVersion) - version message
streamNumbersfield is awkward - High-level checkings (like connection to self detection) probably should lie in transport code
- Exceptions in transport callbacks propogated further: do we want to auto-catch and warn about them?
- Somehow make it clear that methods like
tryDecodeandvalidatedon't throw exceptions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels