From a57b2563a3eb9a7b036f51dd6874444c2478763b Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 26 May 2026 11:15:44 +0000 Subject: [PATCH] =?UTF-8?q?chore:=20remove=20dead=20code=20in=20crawler.py?= =?UTF-8?q?=20=E2=80=94=20CONFIG=5FPREFIXES=5FOF=5FINTEREST=20and=20top=20?= =?UTF-8?q?variable?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two orphaned remnants of an incomplete filtering design: 1. CONFIG_PREFIXES_OF_INTEREST — defined at module level but never referenced in any code. The docstring of _extract_properties_prefixes claimed the function filtered against this constant, but it never did. 2. top = key.split(".", 1)[0] in _extract_properties_prefixes — assigned but never read; would have been used for the filter that was never wired. Both were noted as follow-ups in the PR #15 and PR #16 review notes. Zero behaviour change: top was never read, so removing it cannot affect output. Updated the docstring to describe what the function actually does. 172 tests pass unchanged. Co-Authored-By: Claude Sonnet 4.6 --- tools/skill_generator/crawler.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tools/skill_generator/crawler.py b/tools/skill_generator/crawler.py index be79a44..dd2de3b 100644 --- a/tools/skill_generator/crawler.py +++ b/tools/skill_generator/crawler.py @@ -55,12 +55,6 @@ GENERATED_MARKERS = ("// DO NOT EDIT", "@Generated", "// generated by") -CONFIG_PREFIXES_OF_INTEREST = ( - "datasource", "spring.datasource", "mail", "spring.mail", - "file", "batch", "spring.batch", "queue", "scheduler", - "quartz", "kafka", "redis", "app", "logging", -) - # ───────────────────────────────────────────────────────────────────────────── # Regex parsers (lightweight — no full Java AST library) # ───────────────────────────────────────────────────────────────────────────── @@ -530,8 +524,8 @@ def iter_all(elem): # ───────────────────────────────────────────────────────────────────────────── def _extract_properties_prefixes(text: str) -> list: - """Return distinct prefix keys (everything before the first dot or =) that - match CONFIG_PREFIXES_OF_INTEREST or look meaningful.""" + """Return distinct two-segment key prefixes (e.g. 'spring.datasource') + found in a .properties file, preserving encounter order.""" seen = [] for line in text.splitlines(): line = line.strip() @@ -546,7 +540,6 @@ def _extract_properties_prefixes(text: str) -> list: continue if not key: continue - top = key.split(".", 1)[0] prefix_full = ".".join(key.split(".")[:2]) if "." in key else key if prefix_full not in seen: seen.append(prefix_full)