Skip to content

Commit 9330dd5

Browse files
Copilotbinarywang
andcommitted
添加表单字段参数验证和测试
Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
1 parent 7e34702 commit 9330dd5

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed

weixin-java-common/src/main/java/me/chanjar/weixin/common/bean/CommonUploadParam.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,12 @@ public static CommonUploadParam fromBytes(String name, @Nullable String fileName
7575
* @return 当前对象,支持链式调用
7676
*/
7777
public CommonUploadParam addFormField(String fieldName, String fieldValue) {
78+
if (fieldName == null || fieldName.trim().isEmpty()) {
79+
throw new IllegalArgumentException("表单字段名不能为空");
80+
}
81+
if (fieldValue == null) {
82+
throw new IllegalArgumentException("表单字段值不能为null");
83+
}
7884
if (this.formFields == null) {
7985
this.formFields = new HashMap<>();
8086
}

weixin-java-common/src/test/java/me/chanjar/weixin/common/bean/CommonUploadParamTest.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,4 +95,25 @@ public void testToString() {
9595
Assert.assertTrue(str.contains("name:media"));
9696
Assert.assertTrue(str.contains("formFields:"));
9797
}
98+
99+
@Test(expectedExceptions = IllegalArgumentException.class)
100+
public void testAddFormFieldWithNullFieldName() {
101+
File file = new File("test.txt");
102+
CommonUploadParam param = CommonUploadParam.fromFile("media", file);
103+
param.addFormField(null, "value");
104+
}
105+
106+
@Test(expectedExceptions = IllegalArgumentException.class)
107+
public void testAddFormFieldWithEmptyFieldName() {
108+
File file = new File("test.txt");
109+
CommonUploadParam param = CommonUploadParam.fromFile("media", file);
110+
param.addFormField("", "value");
111+
}
112+
113+
@Test(expectedExceptions = IllegalArgumentException.class)
114+
public void testAddFormFieldWithNullFieldValue() {
115+
File file = new File("test.txt");
116+
CommonUploadParam param = CommonUploadParam.fromFile("media", file);
117+
param.addFormField("fieldName", null);
118+
}
98119
}

0 commit comments

Comments
 (0)