missing register in model714. "DCV". The entire Model714 may be broken.

[chrisbess707]

I believe there is a missing register in model714.rs.

Specifically "DCV" is defined in model_714.json on line 80. But looking in model714.rs I would expect to see this register defined roughly between lines 21 and 24. with all the various support code in other parts of the code.

Because of the way the OFFSETS are defined around line 59. I suspect this entire model may be broken because the offsets will have an off by one error.

Remember there are 2 hard problems in computer science, naming things, cache invalidation, and off by one errors.

[bikeshedder]

Sorry for the slow response. I wrote a response a couple of weeks ago but seem to have forgotten to press the "Comment" button.

The DCV point missing is caused by repeating groups not being supported yet.

• Add support for nested fields and repeating groups #3

DCV is part of the Prt group and therefore missing.

The implementation for repeating and nested groups is almost complete but I never finished it:

• Add support for nested and repeating groups #5

---

The parsing of the other points is correct though. Nested groups always come after the points of the root group. As the repeated group Prt depends on NPrt you first need to read the NPrt point of the root group and then you know how many Prt groups there are.

[bikeshedder]

I've just pushed a commit to PR #5 which completes the implementation I started a year ago. 🙈

You test the code in the feature/groups branch or wait a few more days when I've cleaned up the mess. I'll make a proper release soon.

[bikeshedder]

Issue #3 is the tracking issue for nested and repeating groups.

I'm currently cleaning up the code and will make a release shortly.

[bikeshedder]

Hey @chrisbess707, I just pushed sunspec version 0.9.0 to crates.io which now supports nested and repeating groups:

📦 https://crates.io/crates/sunspec/0.9.0