Skip to content

Some tests are incomplete (no assertions) #284

@donquixote

Description

@donquixote

Steps to reproduce:

./vendor/bin/phpunit tests --display-all-issues

We get

There was 1 risky test:

1) BigBlueButton\Parameters\CreateMeetingParametersTest::testGetPresentationsAsXMLWithUrlAndFilename
This test did not perform any assertions

/****/tests/Parameters/CreateMeetingParametersTest.php:139

and we get this

There was 1 incomplete test:

1) BigBlueButton\Util\FixturesTest::testCoverageOfFixtures
Not all XML-fixtures are checked regarding correctness:
 - delete_recordings.xml
 - get_recordings.xml
 - publish_recordings.xml
 - send_chat_message.xml
 - update_recordings.xml

/****/tests/Util/FixturesTest.php:101

I am not going to fix these because I don't really know what they are trying to test, and I don't want to get into the weeds..

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions