sync(bfmono): fix(gambit): invalidate build deck label cache on frontmatter changes (+19 more) (bfmono@9ebc474b8)

bft-codebot · bft-codebot · commit ddbff6c4f798 · 2026-02-20T20:11:07.000Z
This PR is an automated gambitmono sync of bfmono Gambit packages.

- Source: `packages/gambit/`
- Core: `packages/gambit/packages/gambit-core/`
- bfmono rev: 9ebc474b8

Changes:
- 9ebc474b8 fix(gambit): invalidate build deck label cache on frontmatter changes
- 04f032d28 feat(simulator-ui): use icon remove action for error context chip
- 71a94654b fix(gambit): validate explicit deck path and stabilize stop test
- 77fa7f139 refactor(gambit-simulator-ui): replace placeholders with reusable callout
- d90d57c08 feat(gambit-simulator-ui): send scenario run errors to workbench chat
- dc7d93a08 refactor(gambit): Fix left drawer
- bdad96a86 chore(repo): pin jsx-runtime imports to react 19.2.4
- 0c787f96d chore(gambit): cut 0.8.5-rc.5 and pin React to 19.2.4
- 0fdcdf864 fix(gambit): unblock npm dnt build for 0.8.5-rc.4
- 48cd964d4 feat(gambit-core): restore built-in exec via host adapter
- b48ad8ec2 chore(gambit): cut 0.8.5-rc.3
- 701935f94 ci(gambit-core): gate npm compatibility in core CI
- 6957cc580 docs(gambit-core): document worker sandbox host contract
- 2eb1ce7c6 test(gambit-core): add unsupported worker sandbox coverage
- 825145eea fix(gambit-core): partition worker sandbox by runtime host
- 1801a5380 refactor(gambit-core): remove built-in exec tool from runtime
- 9db408859 fix(gambit-release): support nested core path and cut 0.8.5-rc.2
- 5e286d3a9 fix(gambit): clean codex smoke temp artifacts under ignored tmp
- 2ce4b7ee8 fix(gambit): resolve local jsr package in release-binaries compile
- e0c706e16 feat(gambit-simulator): show deck labels in build file selector

Do not edit this repo directly; make changes in bfmono and re-run the sync.
diff --git a/simulator-ui/src/Chat.tsx b/simulator-ui/src/Chat.tsx
@@ -6,6 +6,7 @@ import {
 } from "./utils.ts";
 import Button from "./gds/Button.tsx";
 import Callout from "./gds/Callout.tsx";
+import Icon from "./gds/Icon.tsx";
 import {
   ActivityTranscriptRows,
   bucketBuildChatDisplay,
@@ -445,22 +446,25 @@ export function ChatView(props: {
                   <input
                     type="checkbox"
                     checked={scenarioErrorChip.enabled}
+                    aria-label={scenarioErrorChip.enabled
+                      ? "Error context on"
+                      : "Error context off"}
                     onChange={(event) =>
                       onScenarioErrorChipChange?.({
                         ...scenarioErrorChip,
                         enabled: event.target.checked,
                       })}
                     data-testid="workbench-error-chip-toggle"
                   />
-                  <span>{scenarioErrorChip.enabled ? "On" : "Off"}</span>
                 </label>
                 <button
                   type="button"
                   className="link-button workbench-composer-chip-remove"
                   onClick={() => onScenarioErrorChipChange?.(null)}
+                  aria-label="Remove error context"
                   data-testid="workbench-error-chip-remove"
                 >
-                  Remove
+                  <Icon name="times" size={8} />
                 </button>
               </div>
             </div>
diff --git a/simulator-ui/src/gds/Icon.tsx b/simulator-ui/src/gds/Icon.tsx
@@ -9,6 +9,7 @@ import { FlagIcon } from "./icons/Flag.tsx";
 import { HamburgerMenuIcon } from "./icons/HamburgerMenu.tsx";
 import { TrashIcon } from "./icons/Trash.tsx";
 import { ReviewIcon } from "./icons/Review.tsx";
+import { TimesIcon } from "./icons/Times.tsx";
 
 const ICONS = {
   chevronDown: ChevronDownIcon,
@@ -22,6 +23,7 @@ const ICONS = {
   circleInfo: CircleInfoIcon,
   review: ReviewIcon,
   trash: TrashIcon,
+  times: TimesIcon,
 };
 
 export type IconName = keyof typeof ICONS;
diff --git a/simulator-ui/src/gds/icons/Times.tsx b/simulator-ui/src/gds/icons/Times.tsx
@@ -0,0 +1,24 @@
+import React from "react";
+
+type IconProps = React.SVGProps<SVGSVGElement> & {
+  title?: string;
+};
+
+export function TimesIcon({ title, ...props }: IconProps) {
+  return (
+    <svg
+      viewBox="0 0 14 14"
+      fill="none"
+      xmlns="http://www.w3.org/2000/svg"
+      {...props}
+    >
+      {title && <title>{title}</title>}
+      <path
+        fillRule="evenodd"
+        clipRule="evenodd"
+        d="M2.73285 0.492584L7 4.75973L11.2671 0.492584C12.7608 -1.00102 15.001 1.23936 13.5074 2.73285L9.24027 7L13.5074 11.2671C15.001 12.7608 12.7606 15.001 11.2671 13.5074L7 9.24027L2.73285 13.5074C1.23925 15.001 -1.00102 12.7606 0.492584 11.2671L4.75973 7L0.492584 2.73285C-1.00102 1.23925 1.23936 -1.00102 2.73285 0.492584Z"
+        fill="currentColor"
+      />
+    </svg>
+  );
+}
diff --git a/simulator-ui/src/styles.ts b/simulator-ui/src/styles.ts
@@ -1409,12 +1409,12 @@ code:not(pre *) {
   margin: 0;
 }
 .workbench-composer-chip-remove {
-  font-size: 12px;
+  display: flex;
   color: var(--color-text-muted);
   text-decoration: none;
 }
 .workbench-composer-chip-remove:hover {
-  color: var(--color-text);
+  color: var(--color-danger);
 }
 .message-input {
   width: 100%;
diff --git a/src/server.ts b/src/server.ts
@@ -1388,20 +1388,56 @@ export function startWebSocketSimulator(opts: {
     return lower === "prompt.md" || lower.endsWith(".deck.md");
   };
 
+  type BuildDeckLabelCacheEntry = {
+    frontmatterRaw: string | null;
+    label: string | undefined;
+  };
+
+  const buildDeckLabelCache = new Map<string, BuildDeckLabelCacheEntry>();
+
   const readBuildDeckLabel = async (
     fullPath: string,
   ): Promise<string | undefined> => {
     try {
       const text = await Deno.readTextFile(fullPath);
       const lines = text.split(/\r?\n/);
-      if (lines[0] !== "+++") return undefined;
+      if (lines[0] !== "+++") {
+        const cached = buildDeckLabelCache.get(fullPath);
+        if (cached?.frontmatterRaw === null) return cached.label;
+        buildDeckLabelCache.set(fullPath, {
+          frontmatterRaw: null,
+          label: undefined,
+        });
+        return undefined;
+      }
       const endIndex = lines.indexOf("+++", 1);
-      if (endIndex === -1) return undefined;
+      if (endIndex === -1) {
+        const cached = buildDeckLabelCache.get(fullPath);
+        if (cached?.frontmatterRaw === null) return cached.label;
+        buildDeckLabelCache.set(fullPath, {
+          frontmatterRaw: null,
+          label: undefined,
+        });
+        return undefined;
+      }
       const frontmatter = lines.slice(1, endIndex).join("\n");
+      const cached = buildDeckLabelCache.get(fullPath);
+      if (cached?.frontmatterRaw === frontmatter) {
+        return cached.label;
+      }
       const parsed = parseToml(frontmatter) as Record<string, unknown>;
       const label = typeof parsed.label === "string" ? parsed.label.trim() : "";
-      return label.length > 0 ? label : undefined;
+      const resolvedLabel = label.length > 0 ? label : undefined;
+      buildDeckLabelCache.set(fullPath, {
+        frontmatterRaw: frontmatter,
+        label: resolvedLabel,
+      });
+      return resolvedLabel;
     } catch {
+      buildDeckLabelCache.set(fullPath, {
+        frontmatterRaw: null,
+        label: undefined,
+      });
       return undefined;
     }
   };
diff --git a/src/server_routes_state.test.ts b/src/server_routes_state.test.ts
@@ -254,6 +254,111 @@ Body
   await server.finished;
 });
 
+Deno.test("build files API refreshes deck labels when content changes with same size and mtime", async () => {
+  const dir = await Deno.makeTempDir();
+  const modHref = modImportPath();
+
+  const deckPath = path.join(dir, "build-files-label-cache.deck.ts");
+  await Deno.writeTextFile(
+    deckPath,
+    `
+    import { defineDeck } from "${modHref}";
+    import { z } from "zod";
+    export default defineDeck({
+      inputSchema: z.string().optional(),
+      outputSchema: z.string().optional(),
+      modelParams: { model: "dummy-model" },
+    });
+    `,
+  );
+
+  const provider: ModelProvider = {
+    chat() {
+      return Promise.resolve({
+        message: { role: "assistant", content: "ok" },
+        finishReason: "stop",
+      });
+    },
+  };
+
+  const server = startWebSocketSimulator({
+    deckPath,
+    modelProvider: provider,
+    port: 0,
+  });
+  const port = (server.addr as Deno.NetAddr).port;
+
+  const workspaceRes = await fetch(
+    `http://127.0.0.1:${port}/api/workspace/new`,
+    { method: "POST" },
+  );
+  assertEquals(workspaceRes.ok, true);
+  const workspaceBody = await workspaceRes.json() as { workspaceId?: string };
+  const workspaceId = workspaceBody.workspaceId ?? "";
+  assert(workspaceId.length > 0, "missing workspaceId");
+
+  const firstFilesRes = await fetch(
+    `http://127.0.0.1:${port}/api/build/files?workspaceId=${
+      encodeURIComponent(workspaceId)
+    }`,
+  );
+  assertEquals(firstFilesRes.ok, true);
+  const firstFilesBody = await firstFilesRes.json() as { root?: string };
+  const root = firstFilesBody.root ?? "";
+  assert(root.length > 0, "missing bot root");
+
+  const scenarioDir = path.join(root, "scenarios", "scenario_a");
+  await Deno.mkdir(scenarioDir, { recursive: true });
+  const promptPath = path.join(scenarioDir, "PROMPT.md");
+  const fixedTime = new Date("2025-01-01T00:00:00.000Z");
+
+  const makePrompt = (label: string) =>
+    `+++
+label = "${label}"
++++
+
+Body
+`;
+
+  await Deno.writeTextFile(promptPath, makePrompt("Alpha"));
+  await Deno.utime(promptPath, fixedTime, fixedTime);
+
+  const warmCacheRes = await fetch(
+    `http://127.0.0.1:${port}/api/build/files?workspaceId=${
+      encodeURIComponent(workspaceId)
+    }`,
+  );
+  assertEquals(warmCacheRes.ok, true);
+  const warmCacheBody = await warmCacheRes.json() as {
+    entries?: Array<{ path?: string; label?: string }>;
+  };
+  const warmPrompt = (warmCacheBody.entries ?? []).find((entry) =>
+    entry.path === "scenarios/scenario_a/PROMPT.md"
+  );
+  assertEquals(warmPrompt?.label, "Alpha");
+
+  // Same byte length label replacement + identical mtime to reproduce stale-cache risk.
+  await Deno.writeTextFile(promptPath, makePrompt("Bravo"));
+  await Deno.utime(promptPath, fixedTime, fixedTime);
+
+  const refreshedRes = await fetch(
+    `http://127.0.0.1:${port}/api/build/files?workspaceId=${
+      encodeURIComponent(workspaceId)
+    }`,
+  );
+  assertEquals(refreshedRes.ok, true);
+  const refreshedBody = await refreshedRes.json() as {
+    entries?: Array<{ path?: string; label?: string }>;
+  };
+  const refreshedPrompt = (refreshedBody.entries ?? []).find((entry) =>
+    entry.path === "scenarios/scenario_a/PROMPT.md"
+  );
+  assertEquals(refreshedPrompt?.label, "Bravo");
+
+  await server.shutdown();
+  await server.finished;
+});
+
 Deno.test("simulator exposes schema and defaults", async () => {
   const dir = await Deno.makeTempDir();
   const modHref = modImportPath();

Original file line number	Diff line number	Diff line change
`@@ -1409,12 +1409,12 @@ code:not(pre *) {`
`1409`	`1409`	`margin: 0;`
`1410`	`1410`	`}`
`1411`	`1411`	`.workbench-composer-chip-remove {`
`1412`		`- font-size: 12px;`
	`1412`	`+ display: flex;`
`1413`	`1413`	`color: var(--color-text-muted);`
`1414`	`1414`	`text-decoration: none;`
`1415`	`1415`	`}`
`1416`	`1416`	`.workbench-composer-chip-remove:hover {`
`1417`		`- color: var(--color-text);`
	`1417`	`+ color: var(--color-danger);`
`1418`	`1418`	`}`
`1419`	`1419`	`.message-input {`
`1420`	`1420`	`width: 100%;`