Repos inside Beman org don't require code review - let's enforce that

[neatudarius]

Repos inside Beman org don't require code review - let's enforce that

Today I discovered multiple repos (e.g, https://github.com/bemanproject/infra-workflows, https://github.com/bemanproject/cache_latest, https://github.com/bemanproject/transform_view - 10 repos in total) without automatic enforcement for code review in repo.

Technically, we require code review via REPOSITORY.CODEOWNERS and Code Review Guidelines
. Basically, we don't have control over this issue without some administrative actions.

My proposal:

1. Add REPOSITORY.CODE_REVIEW_RULES - Update the Beman Standard: add REPOSITORY.CODE_REVIEW_RULES #158
2. Create bot to query all repos in Beman org, check repo settings (e.g., code review ruleset) and, if problems are found, create issue and assign to an org admin.

TODOs:

• Add REPOSITORY.CODE_REVIEW_RULES
• Add automation

[camio]

This is a reasonable approach. I especially like the fact that a bot is going to enforce this because, otherwise, the Beman standard could grow unwieldy for getting everything right.

[neatudarius]

I will resume this issue (automation) in September, after finishing other infra related stuff. If somebody else is interested, feel free to ping me here.

We still need a resolution https://github.com/bemanproject/infra/issues/146 anyways.

[JeffGarland]

We still need a resolution https://github.com/bemanproject/infra/issues/146 anyways.

@neatudarius that link is a 404? I'd like to make progress on this. Probably the fastest thing is to write issues against the repos and make PRs?

[neatudarius]

I think the repo was renamed/moved. The mentioned issue is bemanproject/beman-tidy#146, where we had a resolution.

[JeffGarland]

I commented there finally -- sorry for the late response. Still, idk that we have to wait for the tool? It seems like we can't directly impact the settings from Exemplar so we still just need to open issues and PRs?

[neatudarius]

we can't directly impact the settings from Exemplar so we still just need to open issues and PRs?

I think we already tried and using a repo as a template does not preserve settings.

[JeffGarland]

Got it. So this is still open due to the need to build automation to check.