Wrong promises handling in bemhtml

[apsavin]

How to reproduce:

1. Create new project with project-stub and bem make
2. Create desktop.bundles/index/index.node.js with the following content:

var Vow = require('../../libs/bem-core/common.blocks/vow/vow.vanilla.js'),
    BEMHTML = require('./index.bemhtml.js').BEMHTML;

var bemjson = {
    block: 'footer',
    content: 'footer content goes here'
};

console.log(BEMHTML.apply(bemjson));

bemjson = {
    block: 'footer',
    content: Vow.resolve('footer content goes here')
};

console.log(BEMHTML.apply(bemjson));

bemjson = {
    block: 'footer',
    content: Vow.resolve({
        block: 'footer',
        content: 'footer content goes here'
    })
};

console.log(BEMHTML.apply(bemjson));

bemjson = {
    block: 'footer',
    content: Vow.resolve({
        block: 'footer',
        content: Vow.resolve('footer content goes here')
    })
};

console.log(BEMHTML.apply(bemjson));

1. Run node desktop.bundles/index/index.node.js

Actual result:

<div class="footer">footer content goes here</div>
<div class="footer">footer content goes here</div>
<div class="footer"><div class="footer">footer content goes here</div></div>
<div class="footer"><div class="footer"><div></div></div></div>

Expected result:

<div class="footer">footer content goes here</div>
<div class="footer">footer content goes here</div>
<div class="footer"><div class="footer">footer content goes here</div></div>
<div class="footer"><div class="footer">footer content goes here</div></div>

[tadatuta]

cc @dfilatov

[dfilatov]

How long has BEMHTML been supporting promises? I know nothing about that.

[apsavin]

@dfilatov see here
More than a year at least.
cc @veged

[narqo]

@apsavin what version of vow do you use?

Ok, it seems that this is a bug in new applyNext internal mechanics. Looks like internal guards don't reset in such cases.

[apsavin]

I'm glad that you've found the cause. Hope to see it fixed soon, the bug is really very nasty. Sorry, I'm without pull request today.

[apsavin]

Can somebody set the "bug" label?

[veged]

@apsavin sorry, it's more complicated than I suppose — we need to integrate this veged/xjst#41

[apsavin]

Oh, I see... Thanks!

[apsavin]

Any news here?