Skip to content

Commit 77052e3

Browse files
authored
Fxi wrong stock order issue during auto-refreshing.
1 parent deb7bc8 commit 77052e3

1 file changed

Lines changed: 10 additions & 12 deletions

File tree

stock-tracker.el

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
;; 0.1.7 Fix US stock not working issue
5353
;; Add test for both CHN and US stocks
5454
;; 0.1.8 Disable test for CHN stocks due to API not working
55+
;; 0.1.9 Fix wrong stock order issue during auto-refreshing
5556

5657
;;; Code:
5758

@@ -261,8 +262,8 @@ It defaults to a comma."
261262
(let ((us-stocks nil))
262263
(dolist (stock stocks)
263264
(when (zerop (string-to-number stock))
264-
(push stock us-stocks)))
265-
(setq us-stocks (reverse us-stocks))))
265+
(setq us-stocks (append us-stocks (list stock)))))
266+
us-stocks))
266267

267268
(defun stock-tracker--get-chn-stocks (stocks)
268269
"Separate chn stock from us stock with `STOCKS'."
@@ -523,8 +524,7 @@ It defaults to a comma."
523524
;; fetch us stocks
524525
(unless (string-empty-p subprocess-us-stocks-string)
525526
(dolist (us-stock (split-string subprocess-us-stocks-string ","))
526-
(push
527-
(stock-tracker--subprocess-request-synchronously us-stock "us-stock") us-result))
527+
(setq us-result (append us-result (list (stock-tracker--subprocess-request-synchronously us-stock "us-stock")))))
528528
(when us-result (map-put! result 'us-stock us-result)))
529529

530530
result))
@@ -546,18 +546,18 @@ It defaults to a comma."
546546

547547
;; format chn stocks
548548
(unless (numberp chn-result)
549-
(push (stock-tracker--format-response chn-result chn-symbol t)
550-
all-collected-stocks-info))
549+
(setq all-collected-stocks-info
550+
(append all-collected-stocks-info (list (stock-tracker--format-response chn-result chn-symbol t)))))
551551

552552
;; format us stocks
553553
(unless (numberp us-result)
554554
(dolist (us-stock us-result)
555-
(push (stock-tracker--format-response us-stock us-symbol t)
556-
all-collected-stocks-info)))
555+
(setq all-collected-stocks-info
556+
(append all-collected-stocks-info (list (stock-tracker--format-response us-stock us-symbol t))))))
557557

558558
;; populate stocks
559559
(when all-collected-stocks-info
560-
(stock-tracker--refresh-content (reverse all-collected-stocks-info)))))))))
560+
(stock-tracker--refresh-content all-collected-stocks-info))))))))
561561

562562
(defun stock-tracker--refresh (&optional asynchronously)
563563
"Refresh list of stocks ASYNCHRONOUSLY or not."
@@ -653,9 +653,7 @@ It defaults to a comma."
653653
(goto-char (point-max))
654654
(insert recved-stocks-info)
655655
(stock-tracker--align-colorize-tables)
656-
(setq stock-tracker-list-of-stocks (reverse stock-tracker-list-of-stocks))
657-
(push stock stock-tracker-list-of-stocks)
658-
(setq stock-tracker-list-of-stocks (reverse stock-tracker-list-of-stocks))
656+
(setq stock-tracker-list-of-stocks (append stock-tracker-list-of-stocks (list stock)))
659657
(set-buffer-modified-p nil))))))
660658

661659
(defun stock-tracker-remove-stock ()

0 commit comments

Comments
 (0)