Replaced string concatenation with template strings

(Mostly) only applied to locations where at least 3 strings were
concatenated.

Request: MO
Change-Id: I23dd131f38068eb0ed0f15ab869665c456e1ce74

Author: TheTechnolog

ui/webapp/src/app/modules/core/components/bd-data-grouping/bd-data-grouping.component.ts

@@ -33,11 +33,26 @@ enum PresetType {
 }
 
 @Component({
-    selector: 'app-bd-data-grouping',
-    templateUrl: './bd-data-grouping.component.html',
-    styleUrls: ['./bd-data-grouping.component.css'],
-    encapsulation: ViewEncapsulation.None,
-    imports: [BdButtonPopupComponent, MatTooltip, MatCard, MatFormField, MatLabel, MatSelect, MatOption, BdButtonComponent, MatDivider, CdkDropList, BdDataGroupingPanelComponent, CdkDrag, MatIcon, CdkDragHandle]
+  selector: 'app-bd-data-grouping',
+  templateUrl: './bd-data-grouping.component.html',
+  styleUrls: ['./bd-data-grouping.component.css'],
+  encapsulation: ViewEncapsulation.None,
+  imports: [
+    BdButtonPopupComponent,
+    MatTooltip,
+    MatCard,
+    MatFormField,
+    MatLabel,
+    MatSelect,
+    MatOption,
+    BdButtonComponent,
+    MatDivider,
+    CdkDropList,
+    BdDataGroupingPanelComponent,
+    CdkDrag,
+    MatIcon,
+    CdkDragHandle,
+  ],
 })
 export class BdDataGroupingComponent<T> implements OnInit, OnChanges {
   private readonly snackBar = inject(MatSnackBar);
@@ -124,7 +139,7 @@ export class BdDataGroupingComponent<T> implements OnInit, OnChanges {
   }
 
   private getStorageKey() {
-    return 'grouping-' + (this.multiple ? 'm-' : 's-') + this.presetKey;
+    return `grouping-${this.multiple ? 'm-' : 's-'}${this.presetKey}`;
   }
 
   private loadPreset() {
@@ -168,7 +183,7 @@ export class BdDataGroupingComponent<T> implements OnInit, OnChanges {
           ({
             name: g.definition.name,
             selected: g.selected,
-          }) as CustomDataGrouping,
+          } as CustomDataGrouping)
       );
   }
 
@@ -184,7 +199,7 @@ export class BdDataGroupingComponent<T> implements OnInit, OnChanges {
   }
 
   private presetTypeKey(): string {
-    return 'preset-type-' + (this.multiple ? 'm-' : 's-') + this.presetKey;
+    return `preset-type-${this.multiple ? 'm-' : 's-'}${this.presetKey}`;
   }
 
   private loadPresetType() {

ui/webapp/src/app/modules/core/components/bd-file-upload/bd-file-upload.component.ts

@@ -70,7 +70,7 @@ export class BdFileUploadComponent<D> implements OnInit {
       return 'Software version already exists. Nothing to do.';
     }
     const softwares: ManifestKey[] = status.detail;
-    return 'New software: ' + softwares.map((key) => key.name + ' ' + key.tag).join(',');
+    return `New software: ${softwares.map((key) => key.name + ' ' + key.tag).join(',')}`;
   }
 
   private getIcon() {

ui/webapp/src/app/modules/core/components/bd-popup/bd-popup.directive.ts

@@ -111,8 +111,8 @@ const RIGHT_BELOW: ConnectedPosition = {
 };
 
 @Directive({
-    selector: '[appBdPopup]',
-    exportAs: 'appBdPopup'
+  selector: '[appBdPopup]',
+  exportAs: 'appBdPopup'
 })
 export class BdPopupDirective implements OnDestroy {
   private readonly host = inject(ElementRef);
@@ -258,7 +258,7 @@ export class BdPopupDirective implements OnDestroy {
     const result: ConnectedPosition[] = [];
     pos.forEach((p) => {
       const x: ConnectedPosition = cloneDeep(p);
-      x.panelClass = x.panelClass + '-' + name;
+      x.panelClass = `${x.panelClass}-${name}`;
       result.push(x);
     });
     return result;

ui/webapp/src/app/modules/core/interceptors/error-handler.interceptor.ts

@@ -55,7 +55,7 @@ export class HttpErrorHandlerInterceptor implements HttpInterceptor {
                 // silent.
               }
               // response status texts are HTML encoded, so we need to decode that here manually.
-              this.snackbar.open(e.status + ': ' + he.decode(e.statusText) + ': ' + displayPath, 'DISMISS', {
+              this.snackbar.open(`${e.status}: ${he.decode(e.statusText)}: ${displayPath}`, 'DISMISS', {
                 panelClass: 'error-snackbar',
               });
               return throwError(() => e);

ui/webapp/src/app/modules/core/services/authentication.service.ts

@@ -317,38 +317,38 @@ export class AuthenticationService {
   }
 
   public getAuthPackForCurrentUser(genFull: boolean): Observable<string> {
-    return this.http.get(this.cfg.config.api + '/auth/auth-pack-self', {
+    return this.http.get(`${this.cfg.config.api}/auth/auth-pack-self`, {
       responseType: 'text',
       params: new HttpParams().append('full', genFull ? 'true' : 'false'),
     });
   }
 
   public getUserInfo(): Observable<UserInfo> {
     this.http
-      .get<UserInfo>(this.cfg.config.api + '/auth/user')
+      .get<UserInfo>(`${this.cfg.config.api}/auth/user`)
       .subscribe((userInfo) => this.userInfoSubject$.next(userInfo));
     return this.userInfoSubject$.asObservable();
   }
 
   public getUserProfileInfo(): Observable<UserProfileInfo> {
-    return this.http.get<UserProfileInfo>(this.cfg.config.api + '/auth/user-profile');
+    return this.http.get<UserProfileInfo>(`${this.cfg.config.api}/auth/user-profile`);
   }
 
   public updateCurrentUser(info: UserInfo): Observable<object> {
     this.userInfoSubject$.next(info);
-    return this.http.post(this.cfg.config.api + '/auth/user', info);
+    return this.http.post(`${this.cfg.config.api}/auth/user`, info);
   }
 
   public removeCurrentUserFromGroup(groupId: string): Observable<object> {
-    return this.http.delete(this.cfg.config.api + '/auth/group/' + groupId);
+    return this.http.delete(`${this.cfg.config.api}/auth/group/${groupId}`);
   }
 
   public deleteCurrentUser(): Observable<object> {
-    return this.http.delete(this.cfg.config.api + '/auth');
+    return this.http.delete(`${this.cfg.config.api}/auth`);
   }
 
   public changePassword(dto: UserChangePasswordDto): Observable<unknown> {
-    return this.http.post(this.cfg.config.api + '/auth/change-password', dto, {
+    return this.http.post(`${this.cfg.config.api}/auth/change-password`, dto, {
       responseType: 'text',
       headers: suppressGlobalErrorHandling(new HttpHeaders()),
     });

ui/webapp/src/app/modules/core/services/config.service.ts

@@ -269,7 +269,7 @@ export class ConfigService {
 
   /** The base URL for a given plugin */
   public getPluginUrl(plugin: PluginInfoDto) {
-    return this.config.api + '/plugins/' + plugin.id.id;
+    return `${this.config.api}/plugins/${plugin.id.id}`;
   }
 
   /** Tries to fetch the current server version, suppresses global error handling */

ui/webapp/src/app/modules/core/services/download.service.ts

@@ -19,7 +19,7 @@ export class DownloadService {
   private readonly cfg = inject(ConfigService);
 
   public buildResponseFileName(productName: string, instanceTemplateName: string) {
-    return 'ResponseFile - ' + productName + ' - ' + instanceTemplateName + '.yaml';
+    return `ResponseFile - ${productName} - ${instanceTemplateName}.yaml`;
   }
 
   /**
@@ -100,6 +100,6 @@ export class DownloadService {
    * Creates a new URL to download a file that has been prepared by another call.
    */
   public createDownloadUrl(token: string) {
-    return this.cfg.config.api + '/download/file/' + token;
+    return `${this.cfg.config.api}/download/file/${token}`;
   }
 }

ui/webapp/src/app/modules/core/services/upload.service.ts

@@ -191,7 +191,7 @@ export class UploadService {
         }
       },
       error: (error: HttpErrorResponse) => {
-        uploadStatus.error = error.statusText + ' (Status ' + error.status + ')';
+        uploadStatus.error = `${error.statusText} (Status ${error.status})`;
         stateSubject.next(UploadState.FAILED);
         progressSubject.complete();
         stateSubject.complete();
@@ -221,7 +221,7 @@ export class UploadService {
           stateSubject.complete();
         },
         error: (error: HttpErrorResponse) => {
-          importStatus.detail = error.statusText + ' (Status ' + error.status + ')';
+          importStatus.detail = `${error.statusText} (Status ${error.status})`;
           stateSubject.next(ImportState.FAILED);
           stateSubject.complete();
         },

ui/webapp/src/app/modules/core/utils/completion.utils.ts

@@ -18,11 +18,12 @@ const RECURSIVE_PREFIXES = ['DELAYED', 'JSON', 'XML', 'YAML'];
 export function getRecursivePrefix(
   word: string,
   acc: string,
-  recursivePrefixes: string[] = RECURSIVE_PREFIXES,
+  recursivePrefixes: string[] = RECURSIVE_PREFIXES
 ): string {
   for (const prefix of recursivePrefixes) {
-    if (word.startsWith(acc + prefix + ':')) {
-      return getRecursivePrefix(word, acc + prefix + ':');
+    const s = `${acc + prefix}:`;
+    if (word.startsWith(s)) {
+      return getRecursivePrefix(word, s);
     }
   }
   return acc;
@@ -110,7 +111,7 @@ export function buildCompletions(
   instance: InstanceConfigurationDto,
   system: SystemConfiguration,
   process: ApplicationConfiguration,
-  apps: ApplicationDto[],
+  apps: ApplicationDto[]
 ): ContentCompletion[] {
   return [
     ...gatherVariableExpansions(instance, system).map((l) => ({

ui/webapp/src/app/modules/core/utils/manifest.utils.ts

@@ -21,7 +21,7 @@ export function getTemplateAppKey(
   template: FlattenedApplicationTemplateConfiguration,
   node: MinionDto,
 ) {
-  return product.product + '/' + template.application + '/' + node.os.toLowerCase();
+  return `${product.product}/${template.application}/${node.os.toLowerCase()}`;
 }
 
 /**