30381 cleaned up some env keys and fixed breadcrumbs (#843)

* - deleted obsolete key VUE_APP_BUSINESSES_URL
- app = 5.5.46
- fixed Business Registry URL in Affiliation Error Modal
- fixed Staff Dashboard breadcrumb

* - updated browserslist

---------

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>

Author: severinbeauvais

app/.env.example

@@ -3,7 +3,6 @@ VUE_APP_PATH="/"
 #vaults web-url
 VUE_APP_REGISTRY_HOME_URL="https://dev.bcregistry.gov.bc.ca/"
 VUE_APP_AUTH_WEB_URL="https://dev.account.bcregistry.gov.bc.ca/"
-VUE_APP_BUSINESSES_URL="https://dev.account.bcregistry.gov.bc.ca/"
 VUE_APP_CORPORATE_ONLINE_URL="https://www.corporateonline.gov.bc.ca"
 VUE_APP_BUSINESS_DASH_URL="https://dev.business-dashboard.bcregistry.gov.bc.ca/"
 VUE_APP_BUSINESS_REGISTRY_URL="https://dev.business-registry-dashboard.bcregistry.gov.bc.ca/"

app/devops/vaults.env

@@ -4,7 +4,6 @@ VUE_APP_PATH=/
 #vaults web-url
 VUE_APP_REGISTRY_HOME_URL="op://web-url/$APP_ENV/registry/REGISTRY_HOME_URL"
 VUE_APP_AUTH_WEB_URL="op://web-url/$APP_ENV/auth-web/AUTH_WEB_URL"
-VUE_APP_BUSINESSES_URL="op://web-url/$APP_ENV/business/BUSINESSES_URL"
 VUE_APP_CORPORATE_ONLINE_URL="op://web-url/$APP_ENV/bcregistry/COLIN_URL"
 VUE_APP_BUSINESS_DASH_URL="op://web-url/$APP_ENV/business-dash/BUSINESS_DASH_URL"
 VUE_APP_BUSINESS_REGISTRY_URL="op://web-url/$APP_ENV/business-registry-ui/BUSINESS_REGISTRY_URL"

app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "name-request",
-  "version": "5.5.45",
+  "version": "5.5.46",
   "private": true,
   "appName": "Name Request UI",
   "sbcName": "SBC Common Components",

app/pnpm-lock.yaml

@@ -92,10 +92,10 @@ export default class AffiliationErrorDialog extends Vue {
   }
 
   get businessRegistryUrl (): string {
-    const businessesUrl = sessionStorage.getItem('BUSINESSES_URL')
+    const businessesUrl = sessionStorage.getItem('BUSINESS_REGISTRY_URL')
     // NB: fall back is user's default account
     const accountId = JSON.parse(sessionStorage.getItem('CURRENT_ACCOUNT')).id || 0
-    return `${businessesUrl}account/${accountId}/business`
+    return `${businessesUrl}account/${accountId}`
   }
 
   protected hideModal (): void {

app/src/components/dialogs/affiliation-error.vue

@@ -6,17 +6,14 @@ export async function getConfig (): Promise<EnvConfigI> {
   // get config from environment
   const windowLocationOrigin = window.location.origin
 
-  if (!{ appBaseURL } || !windowLocationOrigin) {
+  if (!appBaseURL || !windowLocationOrigin) {
     return Promise.reject(new Error('Missing environment variables'))
   }
   axios.defaults.baseURL = appBaseURL
 
   const paymentPortalUrl: string = process.env.VUE_APP_PAYMENT_PORTAL_URL
   sessionStorage.setItem('PAYMENT_PORTAL_URL', paymentPortalUrl)
 
-  const businessesUrl: string = process.env.VUE_APP_BUSINESSES_URL
-  sessionStorage.setItem('BUSINESSES_URL', businessesUrl)
-
   const corporateOnlineUrl: string = process.env.VUE_APP_CORPORATE_ONLINE_URL
   sessionStorage.setItem('CORPORATE_ONLINE_URL', corporateOnlineUrl)
 

app/src/plugins/getConfig.ts

@@ -23,9 +23,9 @@ export function getRegistryHomeBreadcrumb (): BreadcrumbIF {
 }
 
 export function getStaffDashboardBreadcrumb (): BreadcrumbIF {
-  const businessUrl = sessionStorage.getItem('BUSINESSES_URL')
+  const businessUrl = sessionStorage.getItem('AUTH_WEB_URL')
   return {
     text: 'Staff Dashboard',
-    href: `${businessUrl}staff/${getParams()}`
+    href: `${businessUrl}staff/dashboard/active${getParams()}`
   }
 }