Use two-arg sequence constructor

peterdettman · peterdettman · commit d0d4345bc06c · 2025-11-11T23:05:05.000+07:00
diff --git a/core/src/main/java/org/bouncycastle/pqc/crypto/util/PrivateKeyInfoFactory.java b/core/src/main/java/org/bouncycastle/pqc/crypto/util/PrivateKeyInfoFactory.java
@@ -391,13 +391,7 @@ private static XMSSPrivateKey xmssCreateKeyStructure(XMSSPrivateKeyParameters ke
 
     private static ASN1Sequence getBasicPQCEncoding(byte[] seed, byte[] expanded)
     {
-        ASN1EncodableVector v = new ASN1EncodableVector(2);
-
-        v.add(new DEROctetString(seed));
-
-        v.add(new DEROctetString(expanded));
-
-        return new DERSequence(v);
+        return new DERSequence(new DEROctetString(seed), new DEROctetString(expanded));
     }
 
     private static XMSSMTPrivateKey xmssmtCreateKeyStructure(XMSSMTPrivateKeyParameters keyParams)

Original file line number	Diff line number	Diff line change
`@@ -391,13 +391,7 @@ private static XMSSPrivateKey xmssCreateKeyStructure(XMSSPrivateKeyParameters ke`
`391`	`391`
`392`	`392`	`private static ASN1Sequence getBasicPQCEncoding(byte[] seed, byte[] expanded)`
`393`	`393`	`{`
`394`		`- ASN1EncodableVector v = new ASN1EncodableVector(2);`
`395`		`-`
`396`		`- v.add(new DEROctetString(seed));`
`397`		`-`
`398`		`- v.add(new DEROctetString(expanded));`
`399`		`-`
`400`		`- return new DERSequence(v);`
	`394`	`+ return new DERSequence(new DEROctetString(seed), new DEROctetString(expanded));`
`401`	`395`	`}`
`402`	`396`
`403`	`397`	`private static XMSSMTPrivateKey xmssmtCreateKeyStructure(XMSSMTPrivateKeyParameters keyParams)`