Pending Invites and Pending Requests are inverted

[revilo951]

The problem

What the underlying signal-cli reports as pendingMembers is reported by the rest API as pending_requests, and what signal-cli reports as requestingMembers is reported by the rest API as pending_invites

Are you using the latest released version?

• Yes

Have you read the troubleshooting page?

• Yes

What type of installation are you running?

signal-cli-rest-api Docker Container

In which mode are you using the docker container?

JSON-RPC Mode

What's the architecture of your host system?

x86-64

Additional information

No response

[revilo951]

Here's a snippet from the API:

    "pending_invites": [],
    "pending_requests": [
      "+61438snip

And a snippet from running signal-cli --config /home/.local/share/signal-cli -o json listGroups -d -g AIsnip in the container:

    "pendingMembers": [
      {
        "number": "+61438snip

[revilo951]

PR added

[revilo951]

@bbernhard any chance PR #793 could be merged to fix this? It's a very simple change 🙂

[bbernhard]

Sorry, I did miss your PR. Just had a quick look and for some reason it's working for me correctly without your change 🤔

Can you maybe post what you exactly did - will try to reproduce it here then.

[revilo951]

Sorry, I did miss your PR. Just had a quick look and for some reason it's working for me correctly without your change 🤔

Can you maybe post what you exactly did - will try to reproduce it here then.

What I'm seeing is this:

A number that I've invited to join a group, but hasn't yet accepted the invite showing as if they have requested to join the group via the groups join URL

A number that has clicked the groups join URL showing as if they're a number I have invited to the group, but not yet accepted.

Here is another example. In this case, the account that is "pending" in the mobile app is under "Requests" - someone that has requested to join via the groups link.

  {
    "name": "testing groups",
    "description": "blah",
    "id": "group.MFUzZ0R1VHpZVjsnip",
    "internal_id": "0U3gDuTzYVsnip",
    "members": [
      "+61429x",
      "+61439x",
      "+61468x",
      "9b2c5cf8-30x"
    ],
    "blocked": false,
    "pending_invites": [
      "+61488x"
    ],
    "pending_requests": [],
    "invite_link": "https://sig

This is showing them as if they're someone I have added to the group, but haven't accepted yet.

[bbernhard]

got it, thanks!

[revilo951]

Awesome, thanks! Any idea how soon it will be in the docker image? Not sure if that build process is automatic or not?

[bbernhard]

This image bbernhard/signal-cli-rest-api:1772646660-ci contains your changes (as well as the newest signal-cli release). I still want to fix a few other things, before I'll create another official release. But in the meantime you could use the mentioned image - just don't forget to switch back to bbernhard/signal-cli-rest-api:latest once the official release is out ;)

[bbernhard]

a new official version with this change is now out. Thanks for fixing the issue @revilo951