Don't create override font if previousFont is null anyways

ManlyMarco · ManlyMarco · commit 544d1b35cdf3 · 2024-10-27T22:13:53.000+01:00
diff --git a/src/XUnity.AutoTranslator.Plugin.Core/TextTranslationInfo.cs b/src/XUnity.AutoTranslator.Plugin.Core/TextTranslationInfo.cs
@@ -129,8 +129,9 @@ public void ChangeFont( object ui )
             var fontProperty = clrType.CachedProperty( "font" );
 
             var previousFont = fontProperty.Get( ui );
+            if( previousFont == null ) return;
             var newFont = FontCache.GetOrCreateOverrideFontTextMeshPro();
-            if( newFont == null || previousFont == null ) return;
+            if( newFont == null ) return;
 
             if( !UnityObjectReferenceComparer.Default.Equals( newFont, previousFont ) )
             {

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,9 @@ public void ChangeFont( object ui )`
`129`	`129`	`var fontProperty = clrType.CachedProperty( "font" );`
`130`	`130`
`131`	`131`	`var previousFont = fontProperty.Get( ui );`
	`132`	`+ if( previousFont == null ) return;`
`132`	`133`	`var newFont = FontCache.GetOrCreateOverrideFontTextMeshPro();`
`133`		`- if( newFont == null \|\| previousFont == null ) return;`
	`134`	`+ if( newFont == null ) return;`
`134`	`135`
`135`	`136`	`if( !UnityObjectReferenceComparer.Default.Equals( newFont, previousFont ) )`
`136`	`137`	`{`