From 2b5f03ffb5aaf511e95bfd13e1301659f59941fc Mon Sep 17 00:00:00 2001 From: Aaron Moore Date: Tue, 31 Mar 2026 16:14:25 +0100 Subject: [PATCH] Revert "TEMP: Skip media player e2e tests on Local/Test env (#13854)" This reverts commit b13180a8320d690229180187b00becdb261e300a. --- ws-nextjs-app/cypress/e2e/articlePage/testsForAMPOnly.ts | 6 +----- .../cypress/e2e/articlePage/testsForCanonicalOnly.ts | 6 +----- ws-nextjs-app/cypress/e2e/mediaAssetPage/testsForAMPOnly.ts | 6 +----- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/ws-nextjs-app/cypress/e2e/articlePage/testsForAMPOnly.ts b/ws-nextjs-app/cypress/e2e/articlePage/testsForAMPOnly.ts index 6e1022fb10c..ff35a3c229b 100644 --- a/ws-nextjs-app/cypress/e2e/articlePage/testsForAMPOnly.ts +++ b/ws-nextjs-app/cypress/e2e/articlePage/testsForAMPOnly.ts @@ -1,5 +1,4 @@ import { Services } from '#app/models/types/global'; -import getAppEnv from '#cypress/support/helpers/getAppEnv'; import skipOnLocal from '../../support/helpers/skipOnLocal'; import { ServiceParametersType } from '../../types'; import { ampOnly as crossPlatform } from '../assertions/crossPlatformAssertion'; @@ -46,10 +45,7 @@ export default ({ } }); - // TODO: Remove once Test env assets are fixed - const describeOrSkip = getAppEnv() !== 'live' ? describe.skip : describe; - - describeOrSkip('Media Player: AMP', () => { + describe('Media Player: AMP', () => { it('should render an iframe with a valid URL', () => { if (articleHasPlayer(articleId)) { cy.get('[data-e2e="media-player"]').should('be.visible'); diff --git a/ws-nextjs-app/cypress/e2e/articlePage/testsForCanonicalOnly.ts b/ws-nextjs-app/cypress/e2e/articlePage/testsForCanonicalOnly.ts index 2852899bf53..0fe0eaf3511 100644 --- a/ws-nextjs-app/cypress/e2e/articlePage/testsForCanonicalOnly.ts +++ b/ws-nextjs-app/cypress/e2e/articlePage/testsForCanonicalOnly.ts @@ -8,7 +8,6 @@ import { AresMediaMetadataBlock, CaptionBlock, } from '#app/components/MediaLoader/types'; -import getAppEnv from '#cypress/support/helpers/getAppEnv'; import { ServiceParametersType } from '../../types'; import { getBlockData, getBlockByType, getVideoEmbedUrl } from './helpers'; import runIfToggleEnabled from '../../support/helpers/runIfToggleEnabled'; @@ -102,10 +101,7 @@ export default ({ cy.go('back'); }); - // TODO: Remove once Test env assets are fixed - const describeOrSkip = getAppEnv() !== 'live' ? describe.skip : describe; - - describeOrSkip('Media Player: Canonical', () => { + describe('Media Player: Canonical', () => { it('should render a visible placeholder image', () => { cy.window() .getPageDataFromWindow() diff --git a/ws-nextjs-app/cypress/e2e/mediaAssetPage/testsForAMPOnly.ts b/ws-nextjs-app/cypress/e2e/mediaAssetPage/testsForAMPOnly.ts index 2d7f4bd41e3..0cf12488c13 100644 --- a/ws-nextjs-app/cypress/e2e/mediaAssetPage/testsForAMPOnly.ts +++ b/ws-nextjs-app/cypress/e2e/mediaAssetPage/testsForAMPOnly.ts @@ -1,13 +1,9 @@ -import getAppEnv from '#cypress/support/helpers/getAppEnv'; import { ServiceParametersType } from '../../types'; // For testing features that may differ across services but share a common logic e.g. translated strings. export default ({ service, pageType, path }: ServiceParametersType) => { describe(`AMP tests for ${service} ${pageType} ${path}`, () => { - // TODO: Remove once Test env assets are fixed - const describeOrSkip = getAppEnv() !== 'live' ? describe.skip : describe; - - describeOrSkip('Media Player', () => { + describe('Media Player', () => { it('should render an iframe with a valid URL', () => { if (!`${Cypress.env('currentPath')}`.includes('/russian/av/')) { cy.get(`amp-iframe`).should('be.visible');